Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore stat error when no hidden files in directory #1659

Merged
merged 1 commit into from
Nov 18, 2023
Merged

Ignore stat error when no hidden files in directory #1659

merged 1 commit into from
Nov 18, 2023

Conversation

chrjorgensen
Copy link
Collaborator

Changes

This PR will fix the old error of stat complaining cannot stat '.*' by adding a filter for it - like the already filtered error cannot stat '*'.

Checklist

  • have tested my change
  • eslint is not complaining

@chrjorgensen chrjorgensen added the bug A confirmed issue when something isn't working as intended label Nov 18, 2023
@chrjorgensen chrjorgensen added this to the 2.5.0 release milestone Nov 18, 2023
sebjulliand
sebjulliand approved these changes Nov 18, 2023
View reviewed changes
Copy link
Collaborator

@sebjulliand sebjulliand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 😄

@chrjorgensen chrjorgensen merged commit 72d92da into codefori:master Nov 18, 2023
1 check passed
@chrjorgensen
Copy link
Collaborator Author

Thanks @sebjulliand !

@chrjorgensen chrjorgensen deleted the fix/stat-issue branch November 18, 2023 23:02
@sebjulliand sebjulliand linked an issue Nov 19, 2023 that may be closed by this pull request
Opening IFS shortcut works but throws error message "cannot stat '.*'" #1606
Closed
@sebjulliand sebjulliand mentioned this pull request Nov 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebjulliand sebjulliand sebjulliand approved these changes

@worksofliam worksofliam Awaiting requested review from worksofliam

Assignees
No one assigned
Labels
bug A confirmed issue when something isn't working as intended
Projects
None yet
Milestone
2.5.0 release
Development

Successfully merging this pull request may close these issues.

Opening IFS shortcut works but throws error message "cannot stat '.*'"
2 participants
@chrjorgensen @sebjulliand