-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "Run on protected" option on Actions #1664
Conversation
Signed-off-by: Seb Julliand <sebjulliand@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than some label changes, code looks ok to me. Re-request my review when it's ready! This is a neat change.
Signed-off-by: Seb Julliand <sjulliand@arcadsoftware.com>
You're right @worksofliam ; the label we used was actually |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works good for me! This is another nice UX change. You can see in this image that I have a locked member open and don't have any Actions available (as told by the error message).
In this screenshot you can see that I have one or more actions enabled in protected mode, and the list appears with them in correctly.
@sebjulliand Perhaps we should wait for Christian to add the correct translation and also let him test too before this is merged?
Thanks and great stuff!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chrjorgensen Thank you!!
@sebjulliand Over to you for a merge whenever you like 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sebjulliand Beautiful feature - works in my tests. 😍
I made the Danish translation (and fixed some typos). Approved! Merge, Captain! 😃
Thank you guys! You've been brilliant, as always! |
Thanks a million for this enhancement. Makes my life easier when I don't have |
Changes
Resolves #1400
This PR adds a new
Run on protected
attribute to Actions:If this attribute is enabled, then the Action will be allowed to be selected and to run on read-only members or from protected filters.
Before this PR, no action was allowed to run on protected or read-only targets.
Checklist