Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Run on protected" option on Actions #1664

Merged
merged 4 commits into from
Nov 21, 2023
Merged

Conversation

sebjulliand
Copy link
Collaborator

Changes

Resolves #1400

This PR adds a new Run on protected attribute to Actions:
Capture d’écran du 2023-11-19 16-04-49

If this attribute is enabled, then the Action will be allowed to be selected and to run on read-only members or from protected filters.

Before this PR, no action was allowed to run on protected or read-only targets.

Checklist

  • have tested my change

Signed-off-by: Seb Julliand <sebjulliand@gmail.com>
@sebjulliand sebjulliand added the enhancement New feature or request label Nov 19, 2023
@sebjulliand sebjulliand added this to the 2.5.0 release milestone Nov 19, 2023
@sebjulliand sebjulliand requested a review from a team November 19, 2023 15:08
@sebjulliand sebjulliand self-assigned this Nov 19, 2023
Copy link
Contributor

@worksofliam worksofliam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than some label changes, code looks ok to me. Re-request my review when it's ready! This is a neat change.

package.json Outdated Show resolved Hide resolved
src/locale/ids/da.ts Outdated Show resolved Hide resolved
Signed-off-by: Seb Julliand <sjulliand@arcadsoftware.com>
@sebjulliand
Copy link
Collaborator Author

You're right @worksofliam ; the label we used was actually read only elsewhere.
@chrjorgensen may I request your expertise for the Danish translation? 😊

worksofliam
worksofliam previously approved these changes Nov 21, 2023
Copy link
Contributor

@worksofliam worksofliam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works good for me! This is another nice UX change. You can see in this image that I have a locked member open and don't have any Actions available (as told by the error message).

image

In this screenshot you can see that I have one or more actions enabled in protected mode, and the list appears with them in correctly.

image

@sebjulliand Perhaps we should wait for Christian to add the correct translation and also let him test too before this is merged?

Thanks and great stuff!

Copy link
Contributor

@worksofliam worksofliam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chrjorgensen Thank you!!

@sebjulliand Over to you for a merge whenever you like 😄

Copy link
Collaborator

@chrjorgensen chrjorgensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sebjulliand Beautiful feature - works in my tests. 😍

I made the Danish translation (and fixed some typos). Approved! Merge, Captain! 😃

@sebjulliand
Copy link
Collaborator Author

Thank you guys! You've been brilliant, as always!

@sebjulliand sebjulliand merged commit 9dbc63c into master Nov 21, 2023
1 check passed
@sebjulliand sebjulliand deleted the feature/protectedActions branch November 21, 2023 21:14
@m-tyler
Copy link

m-tyler commented Nov 30, 2023

Thanks a million for this enhancement. Makes my life easier when I don't have *ALLOBJ on my user profile.
A list of my actions I marked to run in protected mode. I don't really care if the standard CRT* actions are marked up as we have a CMS tool that should create objects outside of the developer environment.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow for protected filters to run identified user actions
4 participants