Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: extendend content handling srcdat field for unsupported srcdat field values #2472

Closed
wants to merge 0 commits into from

Conversation

crisrivlop
Copy link

@crisrivlop crisrivlop commented Jan 19, 2025

Changes

Add support for Null dates when extendedContent.ts/uploadMemberContentWithDates function is called.

How to test this PR

Examples:

  1. Open a remote file with SRCDAT field in null if extendedMemberSupport property is true. It should open with this new change.

Checklist

  • have tested my change
  • have created one or more test cases
  • updated relevant documentation
  • Remove any/all console.logs I added
  • have added myself to the contributors' list in CONTRIBUTING.md

@sebjulliand
Copy link
Collaborator

I like the idea, but try_cast has been introduced in 7.5 and 7.4 TR6 - and for now, Code for IBM i still supports 7.3 TR 5 at a minimum.
This won't make it's way into the extension until the minimum OS version we supports becomes 7.4 TR6 (which would prevent quite a lot of people from using the extension, sadly).

@worksofliam
Copy link
Contributor

@sebjulliand you are fully right. I also worry about the performance implications of this additional function call. This process is already a little bit slow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants