make NSTemplateTier generator generic & move to common

[MatousJobanek]

depends on codeready-toolchain/toolchain-common#381

• moves most of the nstemplatetier_generator.go into toolchain-common
• loads the metadata & templates from the assets and passes them as a parameter of the generic GenerateTiers function
• drops the test templates and related tests

KUBESAW-59

[mfrancisc]

Great Job 👍

I like how the new nstemplatetiers.GenerateTiers function looks, only nit is that the client needs to depend on a couple of packages potentially:

• the new nstemplatetiers
• the commonclient

Do you see other implementations of the ensureObject function or maybe we could embed that in the nstemplatetiers.GenerateTiers function ?

[fbm3307]

LGTM

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexeykazakov, fbm3307, MatousJobanek, mfrancisc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [MatousJobanek,alexeykazakov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sonarqubecloud]

Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
13.3% Duplication on New Code

See analysis details on SonarCloud

[MatousJobanek]

/retest

[codecov]

Codecov Report

Merging #1006 (07deb94) into master (8ea73da) will decrease coverage by 0.26%.
The diff coverage is 92.30%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1006      +/-   ##
==========================================
- Coverage   84.87%   84.62%   -0.26%     
==========================================
  Files          55       55              
  Lines        5066     4852     -214     
==========================================
- Hits         4300     4106     -194     
+ Misses        583      573      -10     
+ Partials      183      173      -10     

Files	Coverage Δ
controllers/usersignup/usersignup_controller.go	75.77% <ø> (ø)
...plates/nstemplatetiers/nstemplatetier_generator.go	91.30% <92.30%> (+0.58%)	⬆️