Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KUBESAW-250: Updating GolangCiLint to v1.63.1 #1116

Merged
merged 12 commits into from
Jan 13, 2025

Conversation

fbm3307
Copy link
Contributor

@fbm3307 fbm3307 commented Jan 7, 2025

Signed-off-by: Feny Mehta <fbm3307@gmail.com>
MatousJobanek
MatousJobanek previously approved these changes Jan 8, 2025
Signed-off-by: Feny Mehta <fbm3307@gmail.com>
Copy link
Contributor Author

@fbm3307 fbm3307 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The places where i have written // nolint:gosec , it bcoz the linter from 1.60 and above are throwing integer overflow conversion uint->Int and vice versa error , and the fix they have provided seems not working for us, probably, the long term solutions would be to fix this overflow error by not having to convert and only have one ttype of var

pkg/capacity/manager.go Show resolved Hide resolved
Signed-off-by: Feny Mehta <fbm3307@gmail.com>
Copy link
Contributor

@MatousJobanek MatousJobanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix the comments

pkg/capacity/manager.go Outdated Show resolved Hide resolved
pkg/capacity/manager.go Outdated Show resolved Hide resolved
@MatousJobanek MatousJobanek self-requested a review January 9, 2025 13:34
@MatousJobanek MatousJobanek dismissed their stale review January 9, 2025 13:35

dismissing the approval as there are still things to address

Signed-off-by: Feny Mehta <fbm3307@gmail.com>
pkg/capacity/manager.go Outdated Show resolved Hide resolved
pkg/capacity/manager.go Outdated Show resolved Hide resolved
fbm3307 and others added 2 commits January 10, 2025 18:54
…roller.go

Co-authored-by: Matous Jobanek <mjobanek@redhat.com>
Co-authored-by: Matous Jobanek <mjobanek@redhat.com>
fbm3307 and others added 2 commits January 10, 2025 18:54
Co-authored-by: Matous Jobanek <mjobanek@redhat.com>
…roller.go

Co-authored-by: Matous Jobanek <mjobanek@redhat.com>
@fbm3307 fbm3307 requested a review from MatousJobanek January 10, 2025 13:25
Signed-off-by: Feny Mehta <fbm3307@gmail.com>
pkg/space/space.go Outdated Show resolved Hide resolved
Signed-off-by: Feny Mehta <fbm3307@gmail.com>
Copy link

openshift-ci bot commented Jan 13, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fbm3307, MatousJobanek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [MatousJobanek,fbm3307]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fbm3307 fbm3307 merged commit 7841eba into codeready-toolchain:master Jan 13, 2025
11 of 13 checks passed
Copy link

codecov bot commented Jan 13, 2025

Codecov Report

Attention: Patch coverage is 72.22222% with 5 lines in your changes missing coverage. Please review.

Project coverage is 79.16%. Comparing base (69a195d) to head (8fbb7d4).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
main.go 0.00% 3 Missing ⚠️
controllers/space/space_controller.go 0.00% 1 Missing ⚠️
controllers/usersignup/usersignup_controller.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1116      +/-   ##
==========================================
+ Coverage   79.15%   79.16%   +0.01%     
==========================================
  Files          78       78              
  Lines        7809     7814       +5     
==========================================
+ Hits         6181     6186       +5     
  Misses       1449     1449              
  Partials      179      179              
Files with missing lines Coverage Δ
...isionerconfig/spaceprovisionerconfig_controller.go 83.21% <100.00%> (+0.24%) ⬆️
...lers/toolchainconfig/toolchainconfig_controller.go 82.75% <100.00%> (ø)
...lers/toolchainstatus/toolchainstatus_controller.go 88.92% <100.00%> (ø)
pkg/capacity/manager.go 98.50% <100.00%> (+0.02%) ⬆️
pkg/space/space.go 96.20% <100.00%> (+0.04%) ⬆️
controllers/space/space_controller.go 85.53% <0.00%> (ø)
controllers/usersignup/usersignup_controller.go 75.15% <50.00%> (ø)
main.go 0.00% <0.00%> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants