-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KUBESAW-250: Updating GolangCiLint to v1.63.1 #1116
Conversation
Signed-off-by: Feny Mehta <fbm3307@gmail.com>
Signed-off-by: Feny Mehta <fbm3307@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The places where i have written // nolint:gosec , it bcoz the linter from 1.60 and above are throwing integer overflow conversion uint->Int and vice versa error , and the fix they have provided seems not working for us, probably, the long term solutions would be to fix this overflow error by not having to convert and only have one ttype of var
Signed-off-by: Feny Mehta <fbm3307@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please fix the comments
controllers/spaceprovisionerconfig/spaceprovisionerconfig_controller.go
Outdated
Show resolved
Hide resolved
controllers/spaceprovisionerconfig/spaceprovisionerconfig_controller.go
Outdated
Show resolved
Hide resolved
dismissing the approval as there are still things to address
Signed-off-by: Feny Mehta <fbm3307@gmail.com>
controllers/spaceprovisionerconfig/spaceprovisionerconfig_controller.go
Outdated
Show resolved
Hide resolved
controllers/spaceprovisionerconfig/spaceprovisionerconfig_controller.go
Outdated
Show resolved
Hide resolved
…roller.go Co-authored-by: Matous Jobanek <mjobanek@redhat.com>
Co-authored-by: Matous Jobanek <mjobanek@redhat.com>
Co-authored-by: Matous Jobanek <mjobanek@redhat.com>
…roller.go Co-authored-by: Matous Jobanek <mjobanek@redhat.com>
Signed-off-by: Feny Mehta <fbm3307@gmail.com>
Signed-off-by: Feny Mehta <fbm3307@gmail.com>
Quality Gate passedIssues Measures |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fbm3307, MatousJobanek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1116 +/- ##
==========================================
+ Coverage 79.15% 79.16% +0.01%
==========================================
Files 78 78
Lines 7809 7814 +5
==========================================
+ Hits 6181 6186 +5
Misses 1449 1449
Partials 179 179
|
Updating the GolangciLint to v1.63.1 across all repos fix the Linter error which were caught as a result of upgrading the linter
Similar PRs