Upgrade k8s depencencies in host for Openshift 4.16 #1125
Conversation
ranakan19
requested review from
MatousJobanek,
xcoulon,
alexeykazakov,
rajivnathan and
mfrancisc
as code owners
| Metrics: metricsserver.Options{ | ||
| BindAddress: metricsAddr, | ||
| }, | ||
| WebhookServer: webhookServer, |
There was a problem hiding this comment.
the same question as in the member-operator PR - do we need the webhookServer configured?
There was a problem hiding this comment.
its because port is deprecated and webhookServer replaces it.
from the documentation:
// Port is the port that the webhook server serves at.
// It is used to set webhook.Server.Port if WebhookServer is not set.
//
// Deprecated: Use WebhookServer instead. A WebhookServer can be created via webhook.NewServer.
Port int
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1125 +/- ##
==========================================
- Coverage 79.16% 79.10% -0.07%
==========================================
Files 78 78
Lines 7814 7819 +5
==========================================
- Hits 6186 6185 -1
- Misses 1449 1455 +6
Partials 179 179
|
| HealthProbeBindAddress: probeAddr, | ||
| LeaderElection: enableLeaderElection, | ||
| LeaderElectionID: "dc07038f.toolchain.host.operator", | ||
| Namespace: namespace, | ||
| Cache: cache.Options{DefaultNamespaces: map[string]cache.Config{namespace: {}}}, |
There was a problem hiding this comment.
I remember we discussed it and you explained how this new Cache configuration works but I already forgot :)
This configuration looks confusing (why there is default namespace as a map with a key but no value) so maybe you can try to add some comments explaining how it works? Or maybe a link to docs where it's explained. But feel free to leave it as is if it's not trivial.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexeykazakov, ranakan19 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Upgrades:
Changes in code wrt to controller-runtime upgrade (introduced in controller-runtime v0.16.0:
wrt: https://issues.redhat.com/browse/SANDBOX-686