Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade golang to 1.20 #930

Merged
merged 3 commits into from
Nov 14, 2023
Merged

Conversation

ranakan19
Copy link
Contributor

No description provided.

Copy link
Contributor

@xcoulon xcoulon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great! we needed to upgrade to 1.20.10 or higher 🙌

Copy link
Contributor

@mfrancisc mfrancisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

Thanks for taking care of this.

Copy link

openshift-ci bot commented Nov 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexeykazakov, mfrancisc, ranakan19, xcoulon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [alexeykazakov,xcoulon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
13.5% 13.5% Duplication

@ranakan19
Copy link
Contributor Author

/retest

Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Merging #930 (5c47b0a) into master (b4baf2f) will increase coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #930      +/-   ##
==========================================
+ Coverage   83.86%   83.88%   +0.01%     
==========================================
  Files          53       53              
  Lines        6161     6161              
==========================================
+ Hits         5167     5168       +1     
+ Misses        812      811       -1     
  Partials      182      182              

see 1 file with indirect coverage changes

@ranakan19 ranakan19 merged commit 83151b6 into codeready-toolchain:master Nov 14, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants