Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the idler template generic #965

Merged

Conversation

rajivnathan
Copy link
Contributor

This way the template can be reused when VMs are idled too.

https://issues.redhat.com/browse/SANDBOX-513

@openshift-ci openshift-ci bot added the approved label Feb 6, 2024
Copy link

sonarqubecloud bot commented Feb 6, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
12.9% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@ranakan19 ranakan19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

openshift-ci bot commented Feb 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexeykazakov, rajivnathan, ranakan19

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Feb 6, 2024

Codecov Report

Merging #965 (d4ffa2c) into master (0f3f6ce) will decrease coverage by 0.02%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #965      +/-   ##
==========================================
- Coverage   83.68%   83.66%   -0.02%     
==========================================
  Files          55       55              
  Lines        6275     6275              
==========================================
- Hits         5251     5250       -1     
- Misses        838      839       +1     
  Partials      186      186              

see 1 file with indirect coverage changes

@rajivnathan rajivnathan merged commit b52c7c1 into codeready-toolchain:master Feb 6, 2024
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants