Added more memory tier with proper resource access #969
Conversation
Signed-off-by: Bama Charan Kundu <bamachrn@gmail.com>
bamachrn
requested review from
MatousJobanek,
xcoulon,
alexeykazakov,
rajivnathan,
ranakan19,
sbryzak and
mfrancisc
as code owners
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: bamachrn The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Hi @bamachrn. Thanks for your PR. I'm waiting for a codeready-toolchain member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| content, err := assets.Asset(templatePath) | ||
| require.NoError(t, err) | ||
| expected := templatev1.Template{} | ||
| _, _, err = decoder.Decode(content, nil, &expected) | ||
| require.NoError(t, err) | ||
| // then override the templates' parameters (if applicable) | ||
| if basedOnOtherTier(expectedTiers, tier) { |
There was a problem hiding this comment.
I'm not sure why this is needed. Could you please comment on this?
There was a problem hiding this comment.
I believe this comes from my contribution to #944 but I don't recall all the details :/
|
| @@ -39,7 +39,6 @@ objects: | |||
| scopes: | |||
| - NotTerminating | |||
| hard: | |||
| limits.cpu: "20" | |||
There was a problem hiding this comment.
are you sure that you want to remove the quota for cpu limits completely?
|
This PR hasn't been updated for a long time and there are a tons of conflicts. Closing it... |
This is replacement of PR #944