Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copy the SA token of sub-spaces only for specific tiers #972

Merged
merged 24 commits into from
Mar 5, 2024
Merged

Copy the SA token of sub-spaces only for specific tiers #972

merged 24 commits into from
Mar 5, 2024

Conversation

mfrancisc
Copy link
Contributor

@mfrancisc mfrancisc commented Feb 19, 2024 •
edited
Loading

Kartikey-star and others added 16 commits October 23, 2023 11:51
@Kartikey-star
Copy the SA token of sub-spaces only for specific tiers
de3c499 
Signed-off-by: Kartikey Mamgain <kmamgain@redhat.com>
@Kartikey-star
Copy the SA token of sub-spaces only for specific tiers
47aca72 
Signed-off-by: Kartikey Mamgain <kmamgain@redhat.com>
@Kartikey-star
Merge branch 'master' into sa_token_copy
6117ff1
@Kartikey-star
Merge branch 'master' into sa_token_copy
973f674
@mfrancisc
Merge branch 'master' into sa_token_copy
34e49a8
@mfrancisc
Merge branch 'master' into sa_token_copy
2e57912
@mfrancisc
Merge branch 'master' into sa_token_copy
6651095
@mfrancisc
Merge branch 'master' into sa_token_copy
c0aa111
@mfrancisc
Merge branch 'master' into sa_token_copy
0cd9550
@mfrancisc
remove spacebinding request migration controller
8d24435
@mfrancisc
Merge branch 'master' of github.com:mfrancisc/host-operator
a25fb02
@mfrancisc
Merge branch 'master' of github.com:mfrancisc/host-operator
fd840c6
@mfrancisc
Merge branch 'master' of github.com:mfrancisc/host-operator
0221d40
@mfrancisc
Merge branch 'master' of github.com:mfrancisc/host-operator
0f4717d
@mfrancisc
wip address pr comments
fc2edcd
@mfrancisc
Merge branch 'master' into srtoken
ddbd733 
# Conflicts:
#	controllers/spacerequest/spacerequest_controller.go
#	controllers/spacerequest/spacerequest_controller_test.go
@mfrancisc mfrancisc mentioned this pull request Feb 19, 2024
Closed
@mfrancisc mfrancisc mentioned this pull request Feb 20, 2024
Merged
dperaza4dustbit
dperaza4dustbit approved these changes Feb 27, 2024
View reviewed changes
Copy link
Contributor

@dperaza4dustbit dperaza4dustbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 27, 2024

@dperaza4dustbit: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

rajivnathan
rajivnathan reviewed Feb 29, 2024
View reviewed changes
Copy link
Contributor

@rajivnathan rajivnathan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, just a couple minor questions/comments

controllers/spacerequest/spacerequest_controller.go Outdated Show resolved Hide resolved
test/nstemplatetier/nstemplatetier.go Show resolved Hide resolved
controllers/spacerequest/spacerequest_controller_test.go Outdated Show resolved Hide resolved
mfrancisc and others added 3 commits February 29, 2024 11:36
MatousJobanek
MatousJobanek approved these changes Feb 29, 2024
View reviewed changes
Copy link
Contributor

@MatousJobanek MatousJobanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool 👍

rajivnathan
rajivnathan approved these changes Feb 29, 2024
View reviewed changes
Copy link
Contributor

@rajivnathan rajivnathan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looks great 👍

test/nstemplatetier/nstemplatetier.go Outdated Show resolved Hide resolved
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dperaza4dustbit, MatousJobanek, mfrancisc, rajivnathan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

mfrancisc and others added 2 commits February 29, 2024 21:40
@mfrancisc @rajivnathan
Update test/nstemplatetier/nstemplatetier.go
aa36deb 
Co-authored-by: Rajiv Senthilnathan <rajivnathan@gmail.com>
@mfrancisc
Merge branch 'master' into srtoken
07cec46
@mfrancisc
Copy link
Contributor Author

/retest

1 similar comment
@mfrancisc
Copy link
Contributor Author

/retest

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Mar 5, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
7.6% Duplication on New Code

See analysis details on SonarCloud

@mfrancisc
Copy link
Contributor Author

/retest

@codecov Codecov
Copy link

codecov bot commented Mar 5, 2024

Codecov Report

Merging #972 (ad11918) into master (0a2ad1a) will increase coverage by 0.14%.
The diff coverage is 100.00%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #972      +/-   ##
==========================================
+ Coverage   83.64%   83.79%   +0.14%     
==========================================
  Files          55       55              
  Lines        6299     6312      +13     
==========================================
+ Hits         5269     5289      +20     
+ Misses        844      839       -5     
+ Partials      186      184       -2
Files Coverage Δ
...ontrollers/spacerequest/spacerequest_controller.go 88.60% <100.00%> (+1.87%) ⬆️

@mfrancisc mfrancisc merged commit 19f31b4 into codeready-toolchain:master Mar 5, 2024
11 of 12 checks passed
@mfrancisc mfrancisc deleted the srtoken branch March 5, 2024 14:28
@mfrancisc mfrancisc mentioned this pull request Apr 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rajivnathan rajivnathan rajivnathan approved these changes

@dperaza4dustbit dperaza4dustbit dperaza4dustbit approved these changes

@MatousJobanek MatousJobanek MatousJobanek approved these changes

@xcoulon xcoulon Awaiting requested review from xcoulon xcoulon is a code owner

@alexeykazakov alexeykazakov Awaiting requested review from alexeykazakov alexeykazakov is a code owner

@ranakan19 ranakan19 Awaiting requested review from ranakan19 ranakan19 is a code owner

@sbryzak sbryzak Awaiting requested review from sbryzak

@sadlerap sadlerap Awaiting requested review from sadlerap

@filariow filariow Awaiting requested review from filariow

Assignees
No one assigned
Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mfrancisc @MatousJobanek @dperaza4dustbit @rajivnathan @Kartikey-star