Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new appstudio limits and quotas #861

Closed
wants to merge 14 commits into from

Conversation

amfred
Copy link

@amfred amfred commented Dec 5, 2023

Copy link

openshift-ci bot commented Dec 5, 2023

Hi @amfred. Thanks for your PR.

I'm waiting for a codeready-toolchain member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

openshift-ci bot commented Dec 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexeykazakov, amfred

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Dec 6, 2023
@alexeykazakov
Copy link
Contributor

/ok-to-test

@amfred
Copy link
Author

amfred commented Dec 15, 2023

/retest

@alexeykazakov
Copy link
Contributor

/ok-to-test

@alexeykazakov
Copy link
Contributor

/retest

Infra issue

@amfred
Copy link
Author

amfred commented Dec 19, 2023

/retest

@amfred
Copy link
Author

amfred commented Dec 19, 2023

I don't think this test failure is related to my change, and the corresponding tests on the host-operator are passing:
`

: Find all of the input images from ocp/4.14 and tag them into the stable stream expand_less 34s
{ could not create snapshot imagestream ocp/4.14 for release latest: Timeout: request did not complete within requested timeout - context deadline exceeded}

`

@alexeykazakov
Copy link
Contributor

It looks like an openshift-ci infra issue.

@amfred
Copy link
Author

amfred commented Dec 19, 2023

See the comments on the paired PR; I think we're good to go.

@amfred
Copy link
Author

amfred commented Dec 19, 2023

/retest

@amfred amfred force-pushed the more-memory-quota branch 2 times, most recently from 8f137dd to 16f3fb3 Compare December 19, 2023 22:29
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions

36.1% Duplication on New Code (required ≤ 20%)

See analysis details on SonarCloud

@amfred
Copy link
Author

amfred commented Feb 6, 2024

@bamachrn What are the new PRs that replace this?

@amfred
Copy link
Author

amfred commented Feb 6, 2024

/hold

@MatousJobanek
Copy link
Collaborator

This PR hasn't been updated for a long time and the paired PR is already closed.
I'm closing the PR, feel free to reopen it or create a new one if you still need to update the tiers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants