Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: template variables and annotations for API v1 #94

Merged
merged 15 commits into from
Mar 6, 2020
Merged

Conversation

mrtraser
Copy link
Contributor

@mrtraser mrtraser commented Mar 5, 2020

No description provided.

@jenkins-cognite
Copy link

[pr-bot]
Run this build with docker run --rm -it -p 3000:3000 cognite/grafana-cdp-dev:pr-94

@jenkins-cognite
Copy link

[pr-bot]
Run this build with docker run --rm -it -p 3000:3000 cognite/grafana-cdp-dev:pr-94

@jenkins-cognite
Copy link

[pr-bot]
Run this build with docker run --rm -it -p 3000:3000 cognite/grafana-cdp-dev:pr-94

@jenkins-cognite
Copy link

[pr-bot]
Run this build with docker run --rm -it -p 3000:3000 cognite/grafana-cdp-dev:pr-94

@jenkins-cognite
Copy link

[pr-bot]
Run this build with docker run --rm -it -p 3000:3000 cognite/grafana-cdp-dev:pr-94

@mrtraser mrtraser marked this pull request as ready for review March 5, 2020 13:52
@mrtraser mrtraser requested review from polomani and hhenriques March 5, 2020 13:52
@jenkins-cognite
Copy link

[pr-bot]
Run this build with docker run --rm -it -p 3000:3000 cognite/grafana-cdp-dev:pr-94

Copy link
Contributor

@polomani polomani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really love the pr (although I didn't test how it works, but the code is really nice)
some minor things to fix

src/__tests__/__snapshots__/query-parser.test.ts.snap Outdated Show resolved Hide resolved
src/__tests__/annotations.test.ts Show resolved Hide resolved
src/__tests__/annotations.test.ts Show resolved Hide resolved
src/__tests__/annotations.test.ts Show resolved Hide resolved
src/__tests__/metrics.test.ts Show resolved Hide resolved
src/__tests__/query-parser.test.ts Outdated Show resolved Hide resolved
src/annotation_ctrl.ts Show resolved Hide resolved
src/datasource.ts Outdated Show resolved Hide resolved
src/query-parser/query-parser.ts Outdated Show resolved Hide resolved
src/query-parser/query-parser.ts Outdated Show resolved Hide resolved
mrtraser and others added 2 commits March 6, 2020 11:06
Co-Authored-By: Ivan Polomani <ivan.polomanyi@cognite.com>
@jenkins-cognite
Copy link

[pr-bot]
Run this build with docker run --rm -it -p 3000:3000 cognite/grafana-cdp-dev:pr-94

@mrtraser mrtraser requested a review from polomani March 6, 2020 13:44
@jenkins-cognite
Copy link

[pr-bot]
Run this build with docker run --rm -it -p 3000:3000 cognite/grafana-cdp-dev:pr-94

@mrtraser mrtraser merged commit c38ae61 into feat/v1 Mar 6, 2020
polomani added a commit that referenced this pull request Jun 29, 2020
* feat: v1 datapoints query

* chore: add grafana to x-cdp-sdk header

* fix: upgraded assets dropdown

* feat: upgrade timeseries dropdown

* feat: upgraded variables request

* feat: upgraded events query

* refactor: minor

* refactor: move request calls to common function

* fix: fix label for timeseries

* refactor: getDataQueryRequestItems

* refactor: messy function in parser

* feat: synthetics (not working, playground)

* refactor: make the code cleaner

* feat: auto-pagination for 10k timeseries (+some fixes)

* fix: fetching timeseries by id (#92)

* fix: template variables and annotations for API v1 (#94)

* fix: rewrite hints for template variables and annotations (#95)

* fix: parse annotation query with variable in it

* feat: playground synthetics from scratch (#97)

* docs(hint): fix sts function syntax

* fix: array server filters

* feat: support grafana advanced variables syntax

* fix: expand description with docs links (#100)

* feat: error handling for STS, annotation and variables (#99)

* docs: missing comma in template variable hint

Co-Authored-By: Maciej Mrowiec <maciej.mrowiec@cognite.com>

* docs(readme): update sts syntax

* chore: 1.1.0 version bump

* Fix/multiple (#103)

* fix: allow boolean/number/null as != filter

* fix: refresh on input field change

* fix: parse escape char (#104)

* fix: explorer page infinite reloading (#107)

* fix: caching requests (#106)

* feat: add unary minus parser support (#108)

* chore: bump version 2.0.0 (#110)

* chore: rename image to CDF

* Update README.md

* docs: dashboard development (#109)

* fix: per datapoint error handling (#112)

* fix: variables list appearance in grafana v7.0

* fix: default values of aggregates in STS (#105)

* fix: point sts to v1 (#114)

* fix: vulnerabilities, upgrade typescript 3.8, jest 26

* fix: add default granularity for sts query with only id filter

* Add release notes for Grafana 2.0.0

* Fix links in release notes.

* Centralise all usage documentation do documentation portal.

Direct users to support portal instead github issues.

* Readme cleanups.

Keep it simple, all installation, upgrade, setup and user documentation are part of our main dos portal.

* docs: links to docs portal

Co-authored-by: Cognite CICD <cognite-cicd@users.noreply.github.com>
Co-authored-by: Roman Vizniak <mr.traser@gmail.com>
Co-authored-by: Maciej Mrowiec <maciej.mrowiec@cognite.com>
@polomani polomani deleted the fix/variables branch June 29, 2020 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants