Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add NFT transfer and balance actions #103

Merged
merged 3 commits into from
Jan 16, 2025

Conversation

phdargen
Copy link
Contributor

@phdargen phdargen commented Jan 9, 2025

What changed? Why?

Added two new actions for NFT (ERC721) support:

  • TransferNftAction: Transfer NFTs between addresses

  • GetBalanceNftAction: Check NFT ownership and balances

These actions enable agents to handle NFT operations similar to existing ERC20 functionality.

@cb-heimdall
Copy link

cb-heimdall commented Jan 9, 2025

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@0xRAG
Copy link
Contributor

0xRAG commented Jan 15, 2025

Thank you for your contribution @phdargen! Can you please rebase your PR with the latest from main? For context, we re-structured the repo to house both the Python and TypeScript variant of each package. We went ahead and took care of this for you, thanks again for the contribution 🙏

@cb-heimdall
Copy link

Review Error for 0xRAG @ 2025-01-16 20:44:03 UTC
User cannot review their own commit

@0xRAG 0xRAG merged commit 09f470d into coinbase:master Jan 16, 2025
17 checks passed
@cb-heimdall
Copy link

This Pull Request was merged without enough reviews
Please go here to review and +1

@phdargen
Copy link
Contributor Author

thanks for rebasing @0xRAG, I was just about to get onto it.

Your TypeScript port is also much appreciated.
Now that the packages are combined, should a new feature usually be implemented in both python and ts before opening a PR? Maybe your team could add some guidelines about this in CONTRIBUTING.md.

@0xRAG
Copy link
Contributor

0xRAG commented Jan 17, 2025

thanks for rebasing @0xRAG, I was just about to get onto it.

Your TypeScript port is also much appreciated. Now that the packages are combined, should a new feature usually be implemented in both python and ts before opening a PR? Maybe your team could add some guidelines about this in CONTRIBUTING.md.

It's not necessary, but would be welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants