Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add READMEs to Python Package Dirs to Unblock Poetry Publish #132

Merged
merged 1 commit into from
Jan 17, 2025
Merged

chore: Add READMEs to Python Package Dirs to Unblock Poetry Publish #132

merged 1 commit into from
Jan 17, 2025

Conversation

John-peterson-coinbase
Copy link
Contributor

What changed? Why?

  • Add READMEs to Python Package Dirs to Unblock Poetry Publish
  • Poetry publish does not support relative paths or symlinks

Qualified Impact

@cb-heimdall
Copy link

cb-heimdall commented Jan 17, 2025 •
edited
Loading

✅ Heimdall Review Status

Requirement Status More Info
Reviews ✅ 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@John-peterson-coinbase John-peterson-coinbase merged commit b5f1cce into master Jan 17, 2025
21 checks passed
@John-peterson-coinbase John-peterson-coinbase deleted the fix-poetry-publish-add-readme-to-package-dir branch January 17, 2025 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stat stat stat approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@John-peterson-coinbase @cb-heimdall @stat