Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: action for twitter account details #23

Merged
merged 7 commits into from
Nov 7, 2024
Merged

feat: action for twitter account details #23

merged 7 commits into from
Nov 7, 2024

Conversation

stat
Copy link
Contributor

@stat stat commented Nov 7, 2024

No description provided.

@cb-heimdall
Copy link

cb-heimdall commented Nov 7, 2024 •
edited
Loading

✅ Heimdall Review Status

Requirement Status More Info
Reviews ✅ 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@stat stat force-pushed the christopher.gerber/feat/action-twitter-account-details branch from 77a2179 to 4af4c77 Compare November 7, 2024 06:40
@stat stat marked this pull request as ready for review November 7, 2024 06:41
@stat stat force-pushed the christopher.gerber/feat/action-twitter-account-details branch from daa99c5 to 11665be Compare November 7, 2024 07:02
John-peterson-coinbase
John-peterson-coinbase reviewed Nov 7, 2024
View reviewed changes
cdp-agentkit-core/cdp_agentkit_core/actions/social/twitter/account_details.py Outdated Show resolved Hide resolved
cdp-agentkit-core/cdp_agentkit_core/actions/social/twitter/account_details.py Outdated Show resolved Hide resolved
cdp-agentkit-core/cdp_agentkit_core/actions/social/twitter/account_details.py Outdated Show resolved Hide resolved
cdp-agentkit-core/cdp_agentkit_core/actions/social/twitter/account_details.py Outdated Show resolved Hide resolved
cdp-agentkit-core/cdp_agentkit_core/actions/social/twitter/account_details.py Show resolved Hide resolved
twitter-langchain/examples/account_details/account_details.py Outdated Show resolved Hide resolved
twitter-langchain/twitter_langchain/twitter_api_wrapper.py Outdated Show resolved Hide resolved
stat and others added 3 commits November 7, 2024 09:14
@stat @John-peterson-coinbase
Update cdp-agentkit-core/cdp_agentkit_core/actions/social/twitter/acc…
4a59924 
…ount_details.py

Co-authored-by: John Peterson <98187317+John-peterson-coinbase@users.noreply.github.com>
@stat @John-peterson-coinbase
Update cdp-agentkit-core/cdp_agentkit_core/actions/social/twitter/acc…
155d109 
…ount_details.py

Co-authored-by: John Peterson <98187317+John-peterson-coinbase@users.noreply.github.com>
@stat
implementing John's feedback
934dbc8
@stat stat force-pushed the christopher.gerber/feat/action-twitter-account-details branch from 60396f7 to 934dbc8 Compare November 7, 2024 17:58
John-peterson-coinbase
John-peterson-coinbase approved these changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@John-peterson-coinbase John-peterson-coinbase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

note - we should refactor this package like I did for cdp-langchain to reduce the duplicative wrapping, but it can wait for fast follow

@stat stat merged commit 9126e73 into master Nov 7, 2024
11 checks passed
@stat stat deleted the christopher.gerber/feat/action-twitter-account-details branch November 7, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@John-peterson-coinbase John-peterson-coinbase John-peterson-coinbase approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stat @cb-heimdall @John-peterson-coinbase