Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Remove Action enumeration/re-implementation in Framework Exts #25

Merged
merged 1 commit into from
Nov 7, 2024
Merged

chore: Remove Action enumeration/re-implementation in Framework Exts #25

merged 1 commit into from
Nov 7, 2024

Conversation

John-peterson-coinbase
Copy link
Contributor

@John-peterson-coinbase John-peterson-coinbase commented Nov 7, 2024 •
edited
Loading

  • Implementation in cdp-langchain is no longer required for adding a new action
  • Refactoring to remove extraneous wrapping of action calls

@cb-heimdall
Copy link

cb-heimdall commented Nov 7, 2024 •
edited
Loading

✅ Heimdall Review Status

Requirement Status More Info
Reviews ✅ 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@John-peterson-coinbase John-peterson-coinbase force-pushed the chore-auto-enumerate-actions-in-core branch 4 times, most recently from c4aa2f2 to 62d7ac6 Compare November 7, 2024 16:28
@John-peterson-coinbase John-peterson-coinbase force-pushed the chore-auto-enumerate-actions-in-core branch from 62d7ac6 to 849a390 Compare November 7, 2024 16:28
@John-peterson-coinbase John-peterson-coinbase marked this pull request as ready for review November 7, 2024 16:28
@John-peterson-coinbase John-peterson-coinbase changed the title [WIP] 🚧 chore: Remove Action enumeration/re-implementation in Framework Exts 🚧 chore: Remove Action enumeration/re-implementation in Framework Exts Nov 7, 2024
rohan-agarwal-coinbase
rohan-agarwal-coinbase approved these changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@rohan-agarwal-coinbase rohan-agarwal-coinbase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice refactor - great work!

@John-peterson-coinbase John-peterson-coinbase merged commit 3c2682b into master Nov 7, 2024
11 checks passed
stat pushed a commit that referenced this pull request Nov 7, 2024
@John-peterson-coinbase @stat
chore: Remove Action enumeration/re-implementation in Framework Exts (#…
a542b37 
…25)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohan-agarwal-coinbase rohan-agarwal-coinbase rohan-agarwal-coinbase approved these changes

@alex-stone alex-stone Awaiting requested review from alex-stone

@jazz-cb jazz-cb Awaiting requested review from jazz-cb

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@John-peterson-coinbase @cb-heimdall @rohan-agarwal-coinbase