Skip to content

Commit

Permalink
fix(v0.10.1): Fix faucet transaction link
Browse files Browse the repository at this point in the history
This fixes the faucet transaction method `transaction_link` to return
the transaction link instead of the transaction hash.

This adds a unit test to ensure this is set properly.
  • Loading branch information
alex-stone committed Oct 31, 2024
1 parent 7c1024f commit a060da8
Show file tree
Hide file tree
Showing 6 changed files with 9 additions and 5 deletions.
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@

## Unreleased

## [0.10.1] - 2024-10-31
- Fix Faucet transaction_link to return the correct transaction link instead of transaction hash.

## [0.10.0] - 2024-10-31

### Changed
Expand Down
2 changes: 1 addition & 1 deletion cdp/__version__.py
Original file line number Diff line number Diff line change
@@ -1 +1 @@
__version__ = "0.10.0"
__version__ = "0.10.1"
2 changes: 1 addition & 1 deletion cdp/faucet_transaction.py
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ def transaction_link(self) -> str:
str: The transaction link.
"""
return self.transaction.transaction_hash
return self.transaction.transaction_link

@property
def status(self) -> str:
Expand Down
2 changes: 1 addition & 1 deletion docs/conf.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@

project = 'CDP SDK'
author = 'Coinbase Developer Platform'
release = '0.10.0'
release = '0.10.1'

# -- General configuration ---------------------------------------------------
# https://www.sphinx-doc.org/en/master/usage/configuration.html#general-configuration
Expand Down
4 changes: 2 additions & 2 deletions pyproject.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[project]
name = "cdp-sdk"
version = "0.10.0"
version = "0.10.1"
description = "CDP Python SDK"
readme = "README.md"
authors = [{name = "John Peterson", email = "john.peterson@coinbase.com"}]
Expand Down Expand Up @@ -141,4 +141,4 @@ line-ending = "auto"
known-first-party = ["cdp"]

[tool.coverage.run]
omit = ["cdp/client/*"]
omit = ["cdp/client/*"]
1 change: 1 addition & 0 deletions tests/test_faucet_transaction.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ def test_faucet_tx_initialization(faucet_transaction_factory):

assert isinstance(faucet_transaction, FaucetTransaction)
assert faucet_transaction.transaction_hash == "0xtransactionhash"
assert faucet_transaction.transaction_link == "https://sepolia.basescan.org/tx/0xtransactionlink"
assert faucet_transaction.network_id == "base-sepolia"
assert faucet_transaction.address_id == "0xdestination"
assert faucet_transaction.status.value == "complete"
Expand Down

0 comments on commit a060da8

Please sign in to comment.