Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(PSDK-499): Message Hashing Utilities for EIP-191/712 #23

Merged
merged 1 commit into from
Oct 1, 2024
Merged

feat(PSDK-499): Message Hashing Utilities for EIP-191/712 #23

merged 1 commit into from
Oct 1, 2024

Conversation

John-peterson-coinbase
Copy link
Contributor

What changed? Why?

  • Message hashing utilities
  • hash_message for EIP-191
  • hash_typed_data_message for EIP-712

Qualified Impact

@cb-heimdall
Copy link

cb-heimdall commented Oct 1, 2024 •
edited
Loading

✅ Heimdall Review Status

Requirement Status More Info
Reviews ✅ 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@John-peterson-coinbase John-peterson-coinbase force-pushed the psdk-499-message-hashing-helpers branch from 3d9cbf7 to 13ed96e Compare October 1, 2024 22:48
rohan-agarwal-coinbase
rohan-agarwal-coinbase approved these changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@rohan-agarwal-coinbase rohan-agarwal-coinbase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@John-peterson-coinbase John-peterson-coinbase merged commit ccfca49 into master Oct 1, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohan-agarwal-coinbase rohan-agarwal-coinbase rohan-agarwal-coinbase approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@John-peterson-coinbase @cb-heimdall @rohan-agarwal-coinbase