chore: Release V0.10.0 #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* chore: Bump OpenAPI client * chore: Add network_id to Transaction resource * chore: Update faucet transaction payload This updates the faucet transaction payload to reflect what our API now returns. * feat: Support fetching faucet transaction status * chore: Add status and network to faucet transaction string * chore: Fix typos
✅ Heimdall Review Status
|
John-peterson-coinbase
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
This prepares the Python SDK for release v0.10.0, with the primary change being migrating faucet transactions to be async:
#38
This is taking us from
0.0.9to0.10.0as we are now in parity with our other CDP SDKs:Qualified Impact
The existing faucet paradigm will still create faucet transactions, but it is not guaranteed that they will be confirmed on chain by the time they resolve. Using the
faucet_tx.wait()syntax will ensure that the transaction is no longer pending.