Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(PSDK-782): allow users to send sponsored transactions immediately #73

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

0xRAG
Copy link
Contributor

@0xRAG 0xRAG commented Jan 9, 2025

What changed? Why?

Adds a skipBatching prop to createTransfer to allow devs to instruct transactions to be submitted immediately. This results in quicker submission times: ~2s round trip with skipped batching, vs ~20+.

Qualified Impact

@cb-heimdall
Copy link

cb-heimdall commented Jan 9, 2025

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@0xRAG 0xRAG force-pushed the PSDK-782 branch 2 times, most recently from b71201e to 7b7a606 Compare January 9, 2025 19:26
@0xRAG 0xRAG marked this pull request as ready for review January 9, 2025 19:26
@0xRAG 0xRAG force-pushed the PSDK-782 branch 3 times, most recently from 7cb6b30 to fb10e69 Compare January 9, 2025 23:17
Copy link
Contributor

@John-peterson-coinbase John-peterson-coinbase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 small change. Otherwise LGTM @0xRAG

cdp/wallet.py Outdated Show resolved Hide resolved
@0xRAG 0xRAG merged commit e59a897 into v0.14.0 Jan 14, 2025
7 checks passed
@0xRAG 0xRAG deleted the PSDK-782 branch January 14, 2025 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants