-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(PSDK-782): allow users to send sponsored transactions immediately #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🟡 Heimdall Review Status
|
0xRAG
force-pushed
the
PSDK-782
branch
2 times, most recently
from
January 9, 2025 19:26
b71201e
to
7b7a606
Compare
0xRAG
force-pushed
the
PSDK-782
branch
3 times, most recently
from
January 9, 2025 23:17
7cb6b30
to
fb10e69
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 small change. Otherwise LGTM @0xRAG
John-peterson-coinbase
previously approved these changes
Jan 10, 2025
John-peterson-coinbase
previously approved these changes
Jan 14, 2025
John-peterson-coinbase
approved these changes
Jan 14, 2025
Closed
0xRAG
added a commit
that referenced
this pull request
Jan 14, 2025
0xRAG
added a commit
that referenced
this pull request
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
Adds a skipBatching prop to createTransfer to allow devs to instruct transactions to be submitted immediately. This results in quicker submission times: ~2s round trip with skipped batching, vs ~20+.
Qualified Impact