Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: ExternalAddress derived Address class #76

Merged
merged 1 commit into from
Jan 14, 2025
Merged

chore: ExternalAddress derived Address class #76

merged 1 commit into from
Jan 14, 2025

Conversation

John-peterson-coinbase
Copy link
Contributor

What changed? Why?

  • Add ExternalAddress derived Address class to encapsulate external addresses.

Qualified Impact

@cb-heimdall
Copy link

cb-heimdall commented Jan 14, 2025 •
edited
Loading

✅ Heimdall Review Status

Requirement Status More Info
Reviews ✅ 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@cb-heimdall
Copy link

Review Error for jazz-cb @ 2025-01-14 01:15:30 UTC
User failed mfa authentication, public email is not set on your github profile. see go/mfa-help

@John-peterson-coinbase John-peterson-coinbase merged commit 4307127 into master Jan 14, 2025
7 checks passed
@jazz-cb jazz-cb deleted the chore-add-external-address-child-class branch January 14, 2025 01:23
@0xRAG 0xRAG mentioned this pull request Jan 14, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jazz-cb jazz-cb jazz-cb approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@John-peterson-coinbase @cb-heimdall @jazz-cb