Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: skip faucet e2e tests if limit reached #85

Merged
merged 7 commits into from
Jan 17, 2025
Merged

fix: skip faucet e2e tests if limit reached #85

merged 7 commits into from
Jan 17, 2025

Conversation

stat
Copy link
Contributor

@stat stat commented Jan 17, 2025 •
edited
Loading

What changed? Why?

  • removed faucet tests
  • wrapping faucet calls in try/catch

Qualified Impact

@cb-heimdall
Copy link

cb-heimdall commented Jan 17, 2025 •
edited
Loading

✅ Heimdall Review Status

Requirement Status More Info
Reviews ✅ 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@stat stat marked this pull request as ready for review January 17, 2025 00:21
@stat stat merged commit 494cc92 into master Jan 17, 2025
10 checks passed
@stat stat deleted the christopher.gerber/fix/tests-e2e branch January 17, 2025 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jazz-cb jazz-cb jazz-cb approved these changes

@John-peterson-coinbase John-peterson-coinbase Awaiting requested review from John-peterson-coinbase

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stat @cb-heimdall @jazz-cb