Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] Import/Export WalletData #9

Merged
merged 1 commit into from
Sep 25, 2024
Merged

[chore] Import/Export WalletData #9

merged 1 commit into from
Sep 25, 2024

Conversation

John-peterson-coinbase
Copy link
Contributor

What changed? Why?

  • import and export WalletData so that user's can store 1-1 wallet data in locations other than local file
  • Force update doc generation files when calling make docs

Qualified Impact

@cb-heimdall
Copy link

cb-heimdall commented Sep 25, 2024 •
edited
Loading

✅ Heimdall Review Status

Requirement Status More Info
Reviews ✅ 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@John-peterson-coinbase John-peterson-coinbase force-pushed the chore-import-export-wallet-data branch from c4213c4 to afa96d2 Compare September 25, 2024 14:34
@John-peterson-coinbase John-peterson-coinbase merged commit 6d18e53 into master Sep 25, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohan-agarwal-coinbase rohan-agarwal-coinbase Awaiting requested review from rohan-agarwal-coinbase

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@John-peterson-coinbase @cb-heimdall @rohan-agarwal-coinbase