Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: stabalize e2e test workflow #90

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

feat: stabalize e2e test workflow #90

wants to merge 3 commits into from
+21 −21

Conversation

stat
Copy link
Contributor

@stat stat commented Jan 22, 2025 •
edited
Loading

What changed? Why?

  • configuration changes for serial job execution
  • pinning python 3.10
  • test refinements

e2e tests are failing due to parallel execution using the same set of CDP API credentials, causing multiple transfers to execute concurrently raising nonce errors instead of waiting for the current transaction to complete.

Qualified Impact

@cb-heimdall
Copy link

cb-heimdall commented Jan 22, 2025 •
edited
Loading

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@stat stat marked this pull request as ready for review January 22, 2025 07:05
John-peterson-coinbase
John-peterson-coinbase reviewed Jan 22, 2025
View reviewed changes
Copy link
Contributor

@John-peterson-coinbase John-peterson-coinbase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a summary of what transient errors we are attempting to stabilize as a part of this PR?

.github/workflows/e2e_tests.yml Show resolved Hide resolved
tests/test_e2e.py Show resolved Hide resolved
tests/test_e2e.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@John-peterson-coinbase John-peterson-coinbase Awaiting requested review from John-peterson-coinbase

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stat @cb-heimdall @John-peterson-coinbase