Implementing initial version of Wallet Class #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- new eslint rules for JSDocs - base_sepolia usage replaced with Coinbase.networkList.BaseSepolia - Adding base Wallet class and test cases
erdimaden
force-pushed
the
feat/wallet-class
branch
from
9aa8a2b to
3e39c02
Compare
erdimaden
force-pushed
the
feat/wallet-class
branch
from
3e39c02 to
13e9211
Compare
src/coinbase/coinbase.ts
Outdated
| * @constant | ||
| */ | ||
| static networkList = { | ||
| BaseSepolia: "base_sepolia", |
There was a problem hiding this comment.
Suggested change
| BaseSepolia: "base_sepolia", | |
| BaseSepolia: "base-sepolia", |
src/coinbase/tests/wallet_test.ts
Outdated
| it("should return the correct string representation", async () => { | ||
| const wallet = await Wallet.init(VALID_WALLET_MODEL, client); | ||
| expect(wallet.toString()).toBe( | ||
| `Wallet{id: '${VALID_WALLET_MODEL.id}', networkId: 'base_sepolia'}`, |
There was a problem hiding this comment.
Suggested change
| `Wallet{id: '${VALID_WALLET_MODEL.id}', networkId: 'base_sepolia'}`, | |
| `Wallet{id: '${VALID_WALLET_MODEL.id}', networkId: 'base-sepolia'}`, |
src/coinbase/types.ts
Outdated
Comment on lines
17
to
19
| * @param {CreateWalletRequest} [createWalletRequest] - The wallet creation request. | ||
| * @param {RawAxiosRequestConfig} [options] - Axios request options. | ||
| * @throws {APIError} If the request fails. |
There was a problem hiding this comment.
no longer necessary to type the JSDOC
src/coinbase/types.ts
Outdated
Comment on lines
48
to
51
| * @param {string} walletId - The ID of the wallet the address belongs to. | ||
| * @param {string} addressId - The onchain address of the address that is being fetched. | ||
| * @param {AxiosRequestConfig} [options] - Axios request options. | ||
| * @throws {APIError} If the request fails. |
There was a problem hiding this comment.
types no longer necessary in JSDOC
src/coinbase/types.ts
Outdated
Comment on lines
68
to
69
| * @returns {AxiosPromise<UserModel>} - A promise resolvindg to the User model. | ||
| * @throws {APIError} If the request fails. |
There was a problem hiding this comment.
types no longer necessary in JSDOC
src/coinbase/utils.ts
Outdated
Comment on lines
67
to
68
| * @param {Uint8Array} key - The key to convert. | ||
| * @returns {string} The converted hex string. |
There was a problem hiding this comment.
no longer need typing in the JSDOC param and return
John-peterson-coinbase
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
Updated ESLint rules to enforce proper JSDoc comments.
New format for JSDoc comments:
base_sepoliausage changedInitial Version of Wallet Class and Test Cases
Qualified Impact