[PSDK-119] Initial README #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
John-peterson-coinbase
force-pushed
the
psdk-119-readme-init
branch
from
f56892f to
60c8f66
Compare
John-peterson-coinbase
force-pushed
the
psdk-119-readme-init
branch
from
60c8f66 to
9d64b9d
Compare
erdimaden
previously approved these changes
May 16, 2024
cb-heimdall
dismissed
erdimaden’s stale review
Approved review 2061877296 from erdimaden is now dismissed due to new commit. Re-request for approval.
yuga-cb
reviewed
May 17, 2024
| After running `npx ts-node` to start the REPL, you can import the SDK as follows: | ||
|
|
||
| ```typescript | ||
| import { Coinbase } from '@coinbase/coinbase-sdk'; |
There was a problem hiding this comment.
Wouldn't they also need to do npm install?
There was a problem hiding this comment.
The assumption made was that the developer would do npm install above in their project and run the Repl from there. If that is unclear, I can update! @yuga-cb
yuga-cb
reviewed
May 17, 2024
| ```bash | ||
| npm install @coinbase/coinbase-sdk | ||
| ``` | ||
|
|
There was a problem hiding this comment.
added in most recent commit!
yuga-cb
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
Qualified Impact