Refactor wallet creation to split default address creation #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-stone
force-pushed
the
stone/refactor-wallet-creation
branch
from
4f4ceb6 to
7ff1cdd
Compare
This refactors wallet creation to split out default address creation to be in the `.create` method and not in the initialize method. This parallels the ruby SDK changes made in: coinbase/coinbase-sdk-ruby#50
alex-stone
force-pushed
the
stone/refactor-wallet-creation
branch
from
7ff1cdd to
58a51ab
Compare
|
@erdimaden had to update my commit to make sure it was properly signed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
This refactors wallet creation to split out default address creation to be in the
.createmethod and not in the initialize method.This parallels the ruby SDK changes made in:
coinbase/coinbase-sdk-ruby#50
Qualified Impact
This makes changes to the wallet creation and initialization flow.