Implementing getWallet functionality #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erdimaden
force-pushed
the
feat/getWallets
branch
from
cd6f347 to
ffe000f
Compare
erdimaden
changed the title
alex-stone
reviewed
May 23, 2024
| walletsModels.push(wallet); | ||
| } | ||
| for (const wallet of walletsModels) { | ||
| const addressList = await Coinbase.apiClients.address!.listAddresses( |
There was a problem hiding this comment.
Are we fetching these all synchronously?
Curious if we can easily fetches these concurrently, and then wait for all the responses before stitching them back together?
Not blocking, but this is much easier in JS than in ruby to do (and easiest in golang 😂).
alex-stone
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
addressCountparameter and addingaddressModelsderiveAddressmethodQualified Impact