Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Release 0.11.1 with Correlation Data Patch Fix #328

Merged
merged 1 commit into from
Dec 2, 2024
Merged

chore: Release 0.11.1 with Correlation Data Patch Fix #328

merged 1 commit into from
Dec 2, 2024

Conversation

John-peterson-coinbase
Copy link
Contributor

What changed? Why?

  • Support setting source and sourceVersion correlation data via Coinbase.configure()
  • Release v0.11.1

Qualified Impact

@cb-heimdall
Copy link

cb-heimdall commented Nov 29, 2024 •
edited
Loading

✅ Heimdall Review Status

Requirement Status More Info
Reviews ✅ 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

rohan-agarwal-coinbase
rohan-agarwal-coinbase approved these changes Dec 2, 2024
View reviewed changes
Copy link
Contributor

@rohan-agarwal-coinbase rohan-agarwal-coinbase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the reason that this is user-facing configuration so that cdp-agentkit-nodejs can set it? Since I imagine it's not useful for end users of this SDK?

@John-peterson-coinbase
Copy link
Contributor Author

@rohan-agarwal-coinbase Yes - It is so Agentkit.js can set the values.

@John-peterson-coinbase John-peterson-coinbase merged commit 5c0a2a6 into master Dec 2, 2024
6 checks passed
@John-peterson-coinbase John-peterson-coinbase deleted the chore-patch-correlation-data-source-0.11.1 branch December 2, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohan-agarwal-coinbase rohan-agarwal-coinbase rohan-agarwal-coinbase approved these changes

@alex-stone alex-stone Awaiting requested review from alex-stone

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@John-peterson-coinbase @cb-heimdall @rohan-agarwal-coinbase