Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: wallet address invoke contract input validation #337

Conversation

stat
Copy link
Contributor

@stat stat commented Dec 10, 2024

What changed? Why?

implementing input validation for amount and asset_id.

if an amount is provided, the corresponding asset_id must also be provided

Qualified Impact

@cb-heimdall
Copy link

cb-heimdall commented Dec 10, 2024

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@stat stat force-pushed the christopher.gerber/feat/wallet-address-invoke-contract-input-validation branch from 1266249 to 7deb989 Compare December 10, 2024 21:35
@stat stat merged commit 9cba1ab into master Dec 10, 2024
6 checks passed
@stat stat deleted the christopher.gerber/feat/wallet-address-invoke-contract-input-validation branch December 10, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants