Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(PSDK-670): Support external wallet imports, wallet imports from CDP Python SDK #345

Closed
wants to merge 2 commits into from
Closed

feat(PSDK-670): Support external wallet imports, wallet imports from CDP Python SDK #345

wants to merge 2 commits into from

Conversation

derek-cb
Copy link

What changed? Why?

  • Support external wallet import via BIP-39 mnemonic phrases (12, 15, 18, 21, or 24 words)
  • Support import of wallet data exported from CDP Python SDK
  • Deprecated existing Wallet.import() method in favor of Wallet.load() (more descriptive of the fact that we're loading an existing CDP wallet, not importing one into CDP)

Testing

Tested via:

  • Import of 12, 15, 18, 21, and 24-word mnemonic seed phrases
  • Export of wallets generated via mnemonic seed phrases
  • Import of wallets generated via mnemonic seed phrases, that were then exported
  • Successfully imported wallet exported from CDP Python SDK v0.12.0
  • Successfully imported wallet exported from CDP NodeJS SDK v0.11.0

Qualified Impact

@cb-heimdall
Copy link

cb-heimdall commented Dec 17, 2024 •
edited
Loading

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@derek-cb derek-cb changed the title feat(PSDK-670): Support external wallet imports feat(PSDK-670): Support external wallet imports, wallet imports from CDP Python SDK Dec 17, 2024
@derek-cb derek-cb changed the base branch from master to v0.13.0 December 17, 2024 20:52
@derek-cb derek-cb closed this Dec 17, 2024
@derek-cb derek-cb force-pushed the feat/external-wallet-import branch from 1279406 to 5dae1b3 Compare December 17, 2024 20:58
@derek-cb
- Support external wallet import via BIP-39 mnemonic phrases (12, 15,…
3691fc0 
… 18, 21, or 24 words)

- Support import of wallet data exported from CDP Python SDK
- Deprecated existing Wallet.import() method in favor of Wallet.load() (more descriptive of the fact that we're loading an existing CDP wallet, not importing one into CDP)
@derek-cb derek-cb reopened this Dec 17, 2024
@derek-cb
Copy link
Author

Still need to implement test cases...

@derek-cb derek-cb marked this pull request as ready for review December 17, 2024 22:07
@derek-cb derek-cb closed this Dec 17, 2024
@derek-cb
Copy link
Author

this PR was created from a forked repo, hence E2E tests are failing. re-opening as #347

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alex-stone alex-stone Awaiting requested review from alex-stone

@John-peterson-coinbase John-peterson-coinbase Awaiting requested review from John-peterson-coinbase

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@derek-cb @cb-heimdall