Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: changing wallet seed length #35

Merged
merged 1 commit into from
May 28, 2024
Merged

Conversation

erdimaden
Copy link
Contributor

What changed? Why?

Fix: changing wallet seed length

Qualified Impact

@erdimaden erdimaden merged commit 4e283f4 into master May 28, 2024
6 checks passed
Copy link
Contributor

@alex-stone alex-stone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be nice to assert that generating a totally fresh seed like that can be exported and then properly imported?

Not sure what other edge cases there could be around this issue (or if this only causes an issue on signing?)

@cb-heimdall
Copy link

Review Error for alex-stone @ 2024-05-28 17:59:48 UTC
User failed mfa authentication, public email is not set on your github profile. see go/mfa-help

erdimaden added a commit that referenced this pull request May 31, 2024
* Version changed to 0.0.5

* Fix: changing wallet seed length (#35)

* Updating NPM publish workflow (#36)

* Updating NPM release workflow permission (#37)

* Updating Repo URL in package.json (#38)

* Adding index for dist folder (#39) (#40)

* Downgrading package version (#41)

---------

Co-authored-by: yuga-cb <82042350+yuga-cb@users.noreply.github.com>
erdimaden added a commit that referenced this pull request Jun 3, 2024
)

* Version changed to 0.0.5

* Fix: changing wallet seed length (#35)

* Updating NPM publish workflow (#36)

* Updating Repo URL in package.json (#38)

* Adding index for dist folder (#39) (#40)

* Downgrading package version (#41)

* Adding initial version of e2e test cases

* Updating Repo URL in package.json (#38)

* Downgrading package version (#41)

* Updating E2E tests and fixing setSeed address loading issue

* Adding dry-run check


Co-authored-by: yuga-cb <82042350+yuga-cb@users.noreply.github.com>
@erdimaden erdimaden deleted the fix/updating-seed-size branch June 21, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants