Adding authenticator class and tests #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erdimaden
commented
May 13, 2024
| @@ -12,7 +12,7 @@ | |||
| "format": "prettier -c .prettierrc --write \"**/*.{ts,js,cjs,json,md}\"", | |||
| "format-check": "prettier -c .prettierrc --check \"**/*.{ts,js,cjs,json,md}\"", | |||
| "check": "tsc --noEmit", | |||
| "test": "NODE_OPTIONS=--experimental-vm-modules npx jest --no-cache", | |||
There was a problem hiding this comment.
this prefix prevents to run jest so removing it
alex-stone
reviewed
May 13, 2024
| url: "https://api.cdp.coinbase.com/platform/v1/users/me", | ||
| headers: {} as AxiosHeaders, | ||
| }; | ||
| const authenticator = new CoinbaseAuthenticator("api_key", "private_key"); |
There was a problem hiding this comment.
Should we use the authenticator with the valid api key and private key here to ensures that the error being thrown on authenticateRequest is coming from the invalid config and not prom the invalid private key?
src/coinbase/authenticator.ts
Outdated
| private apiKey: string; | ||
| private privateKey: string; | ||
|
|
||
| /* |
There was a problem hiding this comment.
Suggested change
| /* | |
| /** |
There was a problem hiding this comment.
I think the starting lines have to be double asterisk
John-peterson-coinbase
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
Adding authenticator class and unit tests