Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement separate augmentation phase for Cargo packages #48

Merged
merged 3 commits into from
Dec 9, 2024

Conversation

cottsay
Copy link
Member

@cottsay cottsay commented Dec 9, 2024

In addition to moving non-identity package metadata out of the CargoPackageIdentification extension and into a new CargoPackageAugmentation extension, this change also:

  1. Converts dependencies to use the DependencyDescriptor type
  2. Adds "author" metadata to colcon's "maintainer" metadata
  3. Interprets unspecified versions as 0.0.0 (per cargo docs)

@cottsay cottsay added the enhancement New feature or request label Dec 9, 2024
@cottsay cottsay self-assigned this Dec 9, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 9, 2024

Codecov Report

Attention: Patch coverage is 72.91667% with 13 lines in your changes missing coverage. Please review.

Project coverage is 68.07%. Comparing base (48a4245) to head (dd3815e).

Files with missing lines Patch % Lines
colcon_cargo/package_augmentation/cargo.py 78.37% 3 Missing and 5 partials ⚠️
colcon_cargo/package_identification/cargo.py 54.54% 3 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #48      +/-   ##
==========================================
+ Coverage   67.20%   68.07%   +0.87%     
==========================================
  Files           6        7       +1     
  Lines         247      260      +13     
  Branches       37       44       +7     
==========================================
+ Hits          166      177      +11     
+ Misses         57       55       -2     
- Partials       24       28       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@luca-della-vedova luca-della-vedova self-requested a review December 9, 2024 10:20
Copy link
Member

@luca-della-vedova luca-della-vedova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I created a small PR targeting your branch to test the new feature and make sure we keep a good coverage #49

colcon_cargo/package_augmentation/cargo.py Outdated Show resolved Hide resolved
luca-della-vedova and others added 2 commits December 9, 2024 08:56
Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
@cottsay
Copy link
Member Author

cottsay commented Dec 9, 2024

Thank you for adding tests! This PR now has a net improvement on overall project coverage, but more importantly, the metadata being read is now actually verified.

@cottsay cottsay merged commit a6ab446 into main Dec 9, 2024
17 checks passed
@cottsay cottsay deleted the cottsay/package-augmentation branch December 9, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

3 participants