Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't install crate tracking files #51

Merged
merged 1 commit into from
Dec 24, 2024
Merged

Conversation

cottsay
Copy link
Member

@cottsay cottsay commented Dec 23, 2024

I'm not aware of any build processes in colcon which modify or append to files in the install tree. Since we aren't using these files anyway, we should avoid installing them.

https://doc.rust-lang.org/cargo/commands/cargo-install.html#install-options

By default, Cargo keeps track of the installed packages with a metadata file stored in the installation root directory. This flag tells Cargo not to use or create that file. With this flag, Cargo will refuse to overwrite any existing files unless the --force flag is used. This also disables Cargo’s ability to protect against multiple concurrent invocations of Cargo installing at the same time.

We're already getting --force on this command, and I can't see any reason why installation operations need be aware of each other.

I'm not aware of any build processes in colcon which modify or append to
files in the install tree. Since we aren't using these files anyway, we
should avoid installing them.
@cottsay cottsay added the bug Something isn't working label Dec 23, 2024
@cottsay cottsay self-assigned this Dec 23, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.07%. Comparing base (bb6308e) to head (c24b843).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #51   +/-   ##
=======================================
  Coverage   68.07%   68.07%           
=======================================
  Files           7        7           
  Lines         260      260           
  Branches       44       44           
=======================================
  Hits          177      177           
  Misses         55       55           
  Partials       28       28           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cottsay cottsay merged commit f27a295 into main Dec 24, 2024
17 checks passed
@cottsay cottsay deleted the cottsay/no-tracking-file branch December 24, 2024 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

Successfully merging this pull request may close these issues.

3 participants