Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mixin for Clang #37

Merged
merged 1 commit into from
Jan 9, 2024
Merged

Add mixin for Clang #37

merged 1 commit into from
Jan 9, 2024

Conversation

ChrisThrasher
Copy link
Contributor

@ChrisThrasher ChrisThrasher commented Jan 3, 2024

It's useful to have a Mixin to switches to Clang with also pulling in libc++. This is useful for having access to things like Clang's compiler warnings and its -ftime-trace flag for measuring compile times.

I also believe there are ABI considerations. By sticking to libstdc++ you can more assurance that you can link to 3rd party prebuilt libraries that contain standard library types in their interface.

Copy link
Contributor

@tylerjw tylerjw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@cottsay cottsay merged commit 5f1f770 into colcon:master Jan 9, 2024
1 check passed
@ChrisThrasher ChrisThrasher deleted the clang-mixin branch January 9, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants