Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fixes #2872) Refactoring unused files for "showcase view whole nearby activity" #5870

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

(fixes #2872) Refactoring unused files for "showcase view whole nearby activity" #5870

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6302e17
Added consistency to capitalisation
devbytespark Oct 19, 2024
a960f18
Tried removing the button string
devbytespark Oct 19, 2024
df985e1
localisation: deleted instances of refactored string and removed unus…
devbytespark Oct 20, 2024
cb20b56
refactor: Deleted unused dialog_nearby.xml file and its associated st…
devbytespark Oct 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
76 changes: 0 additions & 76 deletions app/src/main/res/layout/dialog_nearby.xml
View file
Open in desktop

This file was deleted.

1 change: 1 addition & 0 deletions app/src/main/res/layout/fragment_explore_map.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@
android:padding="@dimen/activity_margin_horizontal"
android:singleLine="true"
android:text="@string/search_this_area"
android:textAllCaps="false"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the problem if you don't add this line?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The line was initially included to ensure that the button text aligned with the original TextView string (which has now been removed) as Android Studio defaults buttons to AllCaps. However, since we are removing it, it may no longer be necessary.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about removing this whole button?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While the TextView that used to prompt users to use this button has been refactored and removed, the button remains in the app and is still used in the Map Explore activity, as shown below button_usage

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know what makes the text become uppercase in the first place?
We should fix the root issue rather than address this single symptom.
Would you mind checking whether these are really needed?

app/src//main/res/layout-land/activity_review.xml:        android:textAllCaps="true"
app/src//main/res/layout/bottom_sheet_details_explore.xml:            android:textAllCaps="true"
app/src//main/res/layout/bottom_sheet_details_explore.xml:            android:textAllCaps="true"
app/src//main/res/layout/bottom_sheet_details_explore.xml:          android:textAllCaps="true"
app/src//main/res/layout/fragment_achievements.xml:            android:textAllCaps="true"/>
app/src//main/res/layout/fragment_achievements.xml:            android:textAllCaps="true"/>
app/src//main/res/layout/custom_nearby_tab_layout.xml:        android:textAllCaps="true"
app/src//main/res/layout/activity_review.xml:      android:textAllCaps="true"
app/src//main/res/layout/fragment_review_image.xml:      android:textAllCaps="true"
app/src//main/res/layout/fragment_review_image.xml:      android:textAllCaps="true"

android:textColor="@color/status_bar_blue"
android:visibility="gone"
app:elevation="@dimen/dimen_6" />
Expand Down
1 change: 0 additions & 1 deletion app/src/main/res/values-af/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,6 @@
<string name="about_translate_proceed">Voortgaan</string>
<string name="about_translate_cancel">Kanselleer</string>
<string name="retry">Probeer weer</string>
<string name="showcase_view_whole_nearby_activity">Dit is die plekke in jou omgewing wat foto\'s benodig om hul Wikipedia-artikels te illustreer.\n\nAs u op \'SOEK HIERDIE GEBIED\' klik, word die kaart gesluit en \'n nabygeleë soektog na daardie plek begin.</string>
<string name="no_images_found">Geen afbeeldings gevind!</string>
<string name="error_loading_images">Daar is \'n fout opgetree tydens se die laden van die afbeeldings.</string>
<string name="image_uploaded_by">Opgelaai deur:%$1s</string>
Expand Down
4 changes: 0 additions & 4 deletions app/src/main/res/values-ar/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -348,10 +348,6 @@
<string name="about_translate_proceed">تقدم</string>
<string name="about_translate_cancel">إلغاء</string>
<string name="retry">إعادة المحاولة</string>
<string name="showcase_view_whole_nearby_activity">هذه هي الأماكن القريبة منك التي تحتاج إلى صور لتوضيح مقالات ويكيبيديا الخاصة بها. \n\nيؤدي النقر فوق \"البحث في هذه المنطقة\" إلى إغلاق الخريطة وإطلاق بحث قريب حول هذا الموقع.</string>
<string name="showcase_view_needs_photo">هذا المكان يحتاج إلى صورة.</string>
<string name="showcase_view_has_photo">هذا المكان به صورة بالفعل.</string>
<string name="showcase_view_no_longer_exists">هذه الصفحة لم تعد موجودة.</string>
<string name="no_images_found">لم يتم العثور على صور!</string>
<string name="error_loading_images">حدث خطأ أثناء تحميل الصور.</string>
<string name="image_uploaded_by">%1$s :تم الرفع بواسطة</string>
Expand Down
4 changes: 0 additions & 4 deletions app/src/main/res/values-ast/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,10 +289,6 @@
<string name="about_translate_proceed">Siguir</string>
<string name="about_translate_cancel">Zarrar</string>
<string name="retry">Retentar</string>
<string name="showcase_view_whole_nearby_activity">Estos son sitios cercanos que precisen imaxes para ilustrar los sos artículos de Wikipedia.\n\nAl pulsiar en \'BUSCAR NESTA ÁREA\' bloquiase\'l mapa y llánzase una busca cercana alredor d\'esi llugar.</string>
<string name="showcase_view_needs_photo">Esti llugar precisa una semeya.</string>
<string name="showcase_view_has_photo">Esti llugar yá tien una semeya.</string>
<string name="showcase_view_no_longer_exists">Esti llugar yá nun esiste.</string>
<string name="no_images_found">Nun s\'alcontró nenguna imaxe</string>
<string name="error_loading_images">Asocedió un error al cargar les imáxenes.</string>
<string name="image_uploaded_by">Xubida por: %1$s</string>
Expand Down
1 change: 0 additions & 1 deletion app/src/main/res/values-b+ms+Arab/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,6 @@
<string name="about_translate_title">بهاس</string>
<string name="about_translate_cancel">بطل</string>
<string name="retry">چوبا لاݢي</string>
<string name="showcase_view_needs_photo">تمڤت اين ممرلوکن ݢمبر.</string>
<string name="block_notification_title">دسکت</string>
<string name="menu_search_button">چاري</string>
<string name="title_activity_search">چاري</string>
Expand Down
4 changes: 0 additions & 4 deletions app/src/main/res/values-b+sr+Latn/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,10 +288,6 @@
<string name="about_translate_proceed">Nastavi</string>
<string name="about_translate_cancel">Otkaži</string>
<string name="retry">Pokušaj ponovo</string>
<string name="showcase_view_whole_nearby_activity">Ovo su mesta u Vašoj blizini kojima je potrebna slika da ilustruje njihove članke na Vikipediji.\n\nKlikom na \"PRETRAŽITE OVU OBLAST\" zaključava se mapa i pokreće pretragu u blizini te lokacije.</string>
<string name="showcase_view_needs_photo">Ovom mestu je potrebna fotografija.</string>
<string name="showcase_view_has_photo">Ovo mesto već ima fotografiju.</string>
<string name="showcase_view_no_longer_exists">Ovo mesto više ne postoji.</string>
<string name="no_images_found">Slike nisu pronađene.</string>
<string name="error_loading_images">Došlo je do greške pri učitavanju slika.</string>
<string name="image_uploaded_by">Otpremio/la: %1$s</string>
Expand Down
1 change: 0 additions & 1 deletion app/src/main/res/values-ban/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,6 @@
<string name="about_translate_proceed">Kamargiang</string>
<string name="about_translate_cancel">Wangdé</string>
<string name="retry">Indayang malih</string>
<string name="showcase_view_needs_photo">Genah puniki perlu photo</string>
<string name="no_images_found">Gambar ten katemu!</string>
<string name="image_uploaded_by">Kaunggah olih: %1$s</string>
<string name="block_notification_title">Kacadel</string>
Expand Down
3 changes: 0 additions & 3 deletions app/src/main/res/values-bg/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,9 +232,6 @@
<string name="about_translate">Превеждане</string>
<string name="about_translate_title">Езици</string>
<string name="about_translate_cancel">Отказ</string>
<string name="showcase_view_needs_photo">Това място има нужда от снимка.</string>
<string name="showcase_view_has_photo">От това място вече има снимка.</string>
<string name="showcase_view_no_longer_exists">Това място вече не съществува.</string>
<string name="no_images_found">Не са открити изображения!</string>
<string name="menu_search_button">Търсене</string>
<string name="search_commons">Търсене в Общомедия</string>
Expand Down
2 changes: 0 additions & 2 deletions app/src/main/res/values-blk/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,8 +142,6 @@
<string name="about_translate_proceed">ခွုမ်မာꩻသွုပ်ထဲင်း</string>
<string name="about_translate_cancel">မာꩻတဝ်းဒွုမ်</string>
<string name="retry">မာꩻချာယင်း</string>
<string name="showcase_view_needs_photo">ခင်ႏလမ်းယိုနဝ်ꩻ အဝ်ႏလိုႏဓာတ်ပုင်ႏသြ။</string>
<string name="showcase_view_has_photo">ခင်ႏလမ်းယိုနဝ်ꩻ ဓာတ်ပုင်ႏအဝ်ႏထွူလဲဉ်းတပုင်ႏသြ။</string>
<string name="no_images_found">မော့ꩻတဝ်းဓာတ်ပုင်ႏ</string>
<string name="block_notification_title">ပေ့ꩻဗိဉ်ႏခါꩻ</string>
<string name="app_widget_heading">ဟန်ႏနီꩻ ဓာတ်ပုင်ႏတဲးဝါး</string>
Expand Down
3 changes: 0 additions & 3 deletions app/src/main/res/values-bn/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,9 +297,6 @@
<string name="about_translate_proceed">অগ্রসর</string>
<string name="about_translate_cancel">বাতিল</string>
<string name="retry">পুনঃচেষ্টা করুন</string>
<string name="showcase_view_needs_photo">এই স্থানটির একটি চিত্র দরকার।</string>
<string name="showcase_view_has_photo">এই স্থানের ছবি ইতিমধ্যে বিদ্যমান।</string>
<string name="showcase_view_no_longer_exists">এই জায়গাটি আর নেই।</string>
<string name="no_images_found">কোন চিত্র পাওয়া যায়নি!</string>
<string name="error_loading_images">ছবি লোড করার সময় ত্রুটি ঘটেছে৷</string>
<string name="image_uploaded_by">আপলোড করেছেন: %1$s</string>
Expand Down
1 change: 0 additions & 1 deletion app/src/main/res/values-br/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,7 +263,6 @@
<string name="about_translate_proceed">Kenderc\'hel</string>
<string name="about_translate_cancel">Nullañ</string>
<string name="retry">Klask en-dro</string>
<string name="showcase_view_whole_nearby_activity" fuzzy="true">Lec\'hioù zo en-dro deoc\'h zo ezhomm skeudennoù anezho evit skeudennaouiñ pennadoù Wikipedia</string>
<string name="no_images_found">N\'eus bet kavet skeudenn ebet !</string>
<string name="error_loading_images">Ur fazi zo c\'hoarvezet p\'eo bet karget ar skeudennoù.</string>
<string name="image_uploaded_by">Pellgaset gant:%1$s</string>
Expand Down
3 changes: 0 additions & 3 deletions app/src/main/res/values-ca/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,9 +253,6 @@
<string name="about_translate_proceed">Procedeix</string>
<string name="about_translate_cancel">Cancel·la</string>
<string name="retry">Torna-ho a provar</string>
<string name="showcase_view_needs_photo">Aquest lloc necessita una foto.</string>
<string name="showcase_view_has_photo">Aquest lloc ja té una foto.</string>
<string name="showcase_view_no_longer_exists">Aquest lloc ja no existeix.</string>
<string name="no_images_found">No s’ha trobat cap imatge.</string>
<string name="error_loading_images">S\'ha produït un error en carregar les imatges.</string>
<string name="image_uploaded_by">Carregada per: %1$s</string>
Expand Down
4 changes: 0 additions & 4 deletions app/src/main/res/values-cs/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,10 +275,6 @@
<string name="about_translate_proceed">Pokračovat</string>
<string name="about_translate_cancel">Zrušit</string>
<string name="retry">Zkusit znovu</string>
<string name="showcase_view_whole_nearby_activity">Toto jsou místa poblíž vaší současné polohy, které potřebují fotografie k ilustraci příslušných článků na Wikipedii.\n\nKlepnutím na „PROHLEDAT TUTO OBLAST“ se zamkne mapa a spustí se prohledávání okolí daného místa.</string>
<string name="showcase_view_needs_photo">Toto místo potřebuje obrázek.</string>
<string name="showcase_view_has_photo">Toto místo už má obrázek.</string>
<string name="showcase_view_no_longer_exists">Toto místo už neexistuje.</string>
<string name="no_images_found">Nebyly nalezeny žádné obrázky!</string>
<string name="error_loading_images">Při načítání obrázků došlo k chybě.</string>
<string name="image_uploaded_by">Nahrál/a: %1$s</string>
Expand Down
4 changes: 0 additions & 4 deletions app/src/main/res/values-cy/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,10 +247,6 @@
<string name="about_translate_proceed">Parhau</string>
<string name="about_translate_cancel">Diddymu (canslo)</string>
<string name="retry">Ailgeisio</string>
<string name="showcase_view_whole_nearby_activity">Dyma\'r llefydd sydd angen lluniau ohonyn nhw ar gyfer erthyglau Wicipedia.\n\nMae clicio ar \'Archwilio\'r Lleoliad Hwn\'yn cloi\'r map ac yn lansio archwiliad cyfagos.</string>
<string name="showcase_view_needs_photo">Mae\'r lleoliad yma wirioneddol angen llun ohono!</string>
<string name="showcase_view_has_photo">Mae gan y lleoliad yma lun.</string>
<string name="showcase_view_no_longer_exists">Dyw\'r lle yma ddim bellach yn bodoli.</string>
<string name="no_images_found">Dim delweddau!</string>
<string name="error_loading_images">Cafwyd nam tra\'n llwytho delweddau.</string>
<string name="image_uploaded_by">%1$s wedi uwchlwytho</string>
Expand Down
4 changes: 0 additions & 4 deletions app/src/main/res/values-da/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,10 +302,6 @@
<string name="about_translate_proceed">Fortsæt</string>
<string name="about_translate_cancel">Annullér</string>
<string name="retry">Prøv igen</string>
<string name="showcase_view_whole_nearby_activity">Det er de steder i nærheden af dig, der har brug for billeder til at illustrere deres Wikipedia-artikler.\n\nKlikker du på \'SØG DETTE OMRÅDE\' låser kortet og starter en søgning i området omkring det pågældende sted.</string>
<string name="showcase_view_needs_photo">Dette sted mangler et billede.</string>
<string name="showcase_view_has_photo">Dette sted har allerede et billede.</string>
<string name="showcase_view_no_longer_exists">Dette sted findes ikke længere.</string>
<string name="no_images_found">Ingen billeder fundet!</string>
<string name="error_loading_images">Der opstod en fejl under indlæsningen af billeder.</string>
<string name="image_uploaded_by">Uploadet af: %1$s</string>
Expand Down
4 changes: 0 additions & 4 deletions app/src/main/res/values-de/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,10 +333,6 @@
<string name="about_translate_proceed">Fortfahren</string>
<string name="about_translate_cancel">Abbrechen</string>
<string name="retry">Erneut versuchen</string>
<string name="showcase_view_whole_nearby_activity">Dies sind die Orte in deiner Nähe, die Bilder zur Illustration ihrer Wikipedia-Artikel benötigen.\n\nEin Klick auf „DIESEN BEREICH DURCHSUCHEN“ sperrt die Karte und startet eine Suche um diesen Standort.</string>
<string name="showcase_view_needs_photo">Dieser Ort braucht ein Foto.</string>
<string name="showcase_view_has_photo">Dieser Ort hat bereits ein Foto.</string>
<string name="showcase_view_no_longer_exists">Dieser Ort existiert nicht mehr.</string>
<string name="no_images_found">Keine Bilder gefunden!</string>
<string name="error_loading_images">Beim Laden der Bilder ist ein Fehler aufgetreten.</string>
<string name="image_uploaded_by">Hochgeladen von: %1$s</string>
Expand Down
4 changes: 0 additions & 4 deletions app/src/main/res/values-el/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,10 +317,6 @@
<string name="about_translate_proceed">Συνέχεια</string>
<string name="about_translate_cancel">Ακύρωση</string>
<string name="retry">Επανάληψη</string>
<string name="showcase_view_whole_nearby_activity">Αυτά είναι τα μέρη κοντά σας που χρειάζονται φωτογραφίες για να εικονογραφηθούν τα λήμματά τους στη Βικιπαίδεια.\n\nΚάνοντας κλικ στην «ΑΝΑΖΗΤΗΣΗ ΣΕ ΑΥΤΗ ΤΗΝ ΠΕΡΙΟΧΗ» κλειδώνει ο χάρτης και ξεκινά μια κοντινή αναζήτηση γύρω από αυτή την τοποθεσία.</string>
<string name="showcase_view_needs_photo">Αυτό το μέρος χρειάζεται μια φωτογραφία.</string>
<string name="showcase_view_has_photo">Αυτό το μέρος έχει ήδη μια φωτογραφία.</string>
<string name="showcase_view_no_longer_exists">Αυτό το μέρος δεν υπάρχει πλέον.</string>
<string name="no_images_found">Δε βρέθηκαν εικόνες!</string>
<string name="error_loading_images">Παρουσιάστηκε σφάλμα κατά τη φόρτωση των εικόνων.</string>
<string name="image_uploaded_by">Μεταφορτώθηκε από: %1$s</string>
Expand Down
4 changes: 0 additions & 4 deletions app/src/main/res/values-eo/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,10 +301,6 @@
<string name="about_translate_proceed">Daŭrigi</string>
<string name="about_translate_cancel">Nuligi</string>
<string name="retry">Reprovi</string>
<string name="showcase_view_whole_nearby_activity">Jen lokoj apud vi bezonantajn bildojn por ilustri siajn Vikipediaj artikolojn.\n\nAlklakado de \'Serĉi ĉi tiun areon\' ŝlosas la mapon kaj komencas apudan serĉon ĉirkaŭ tiu loko.</string>
<string name="showcase_view_needs_photo">Ĉi tiu loko bezonas foton.</string>
<string name="showcase_view_has_photo">Ĉi tiu loko jam havas foton.</string>
<string name="showcase_view_no_longer_exists">Ĉi tiu loko ne plu ekzistas.</string>
<string name="no_images_found">Neniuj bildoj trovitaj!</string>
<string name="error_loading_images">Okazis eraro ŝargante la bildojn.</string>
<string name="image_uploaded_by">Alŝutita de: %1$s</string>
Expand Down
4 changes: 0 additions & 4 deletions app/src/main/res/values-es/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,10 +343,6 @@
<string name="about_translate_proceed">Proceder</string>
<string name="about_translate_cancel">Cancelar</string>
<string name="retry">Reintentar</string>
<string name="showcase_view_whole_nearby_activity">Estos son los sitios cercanos a ti necesitan imágenes para ilustrar sus artículos de Wikipedia.\n\n\nCliqueando en \'BUSCA EN ESTE ÁREA\' centrara el mapa e iniciara una búsqueda cercana alrededor de esa ubicación.</string>
<string name="showcase_view_needs_photo">Este sitio necesita una foto.</string>
<string name="showcase_view_has_photo">Este sitio ya tiene una foto.</string>
<string name="showcase_view_no_longer_exists">Este sitio ya no existe.</string>
<string name="no_images_found">No se encontró ninguna imagen.</string>
<string name="error_loading_images">Se produjo un error al cargar las imágenes.</string>
<string name="image_uploaded_by">Cargada por: %1$s</string>
Expand Down
4 changes: 0 additions & 4 deletions app/src/main/res/values-eu/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,10 +265,6 @@
<string name="about_translate_proceed">Jarraitu</string>
<string name="about_translate_cancel">Utzi</string>
<string name="retry">Saiatu berriro</string>
<string name="showcase_view_whole_nearby_activity">Zugandik hurbil dauden leku hauek irudiak behar dituzte beren Wikipedia artikuluak hornitzeko.\n\nSakatu \'EREMU HONETAN BILATU\' mapa zentratzeko eta kokapen horren inguruan bilaketa hasteko.</string>
<string name="showcase_view_needs_photo">Leku honek argazkia behar du.</string>
<string name="showcase_view_has_photo">Leku honek badu argazkia.</string>
<string name="showcase_view_no_longer_exists">Lekua hau ez da existitzen.</string>
<string name="no_images_found">Ez da irudirik aurkitu!</string>
<string name="error_loading_images">Arazo bat egon da irudiak kargatzerakoan.</string>
<string name="image_uploaded_by">Nork igota: %1$s</string>
Expand Down
2 changes: 0 additions & 2 deletions app/src/main/res/values-fa/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,8 +289,6 @@
<string name="about_translate_proceed">ادامه</string>
<string name="about_translate_cancel">لغو</string>
<string name="retry">سعى دوباره</string>
<string name="showcase_view_needs_photo">به تصویری از این مکان نیاز است.</string>
<string name="showcase_view_has_photo">هم‌اکنون تصویری از این مکان وجود دارد.</string>
<string name="no_images_found">تصویری یافت نشد!</string>
<string name="error_loading_images">خطایی هنگام بارگذاری پرونده‌ها رخ داد.</string>
<string name="image_uploaded_by">بارگذاری‌شده توسط: %1$s</string>
Expand Down
Loading