-
-
Notifications
You must be signed in to change notification settings - Fork 564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Stirling-PDF > LibreOffice/unoconv Integration Issues #1322
Merged
michelroegl-brunner
merged 3 commits into
community-scripts:main
from
m6urns:stirling-pdf-fix
Jan 9, 2025
Merged
Fix: Stirling-PDF > LibreOffice/unoconv Integration Issues #1322
michelroegl-brunner
merged 3 commits into
community-scripts:main
from
m6urns:stirling-pdf-fix
Jan 9, 2025
+43
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re a running libreoffice service and setup env variables so they are accessible to StirlingPDF. Modify stirlingPDF service to wait for libreoffice service to start. Enable and explicitly start libreoffice and stirlingPDF services.
Please add/write an short guide here for users that have already an existing LXC (Breaking Change) to update the own LXC |
michelroegl-brunner
requested changes
Jan 8, 2025
Co-authored-by: Michel Roegl-Brunner <73236783+michelroegl-brunner@users.noreply.github.com>
Script validation❌ We found issues in the following changed files: Not executable:
Copyright header line missing or invalid:
Author header line missing or invalid:
License header line missing or invalid:
Source header line missing or invalid:
|
Repairing an existing installation of the Stirling-PDF LXC
|
michelroegl-brunner
previously approved these changes
Jan 9, 2025
MickLesk
changed the title
Fix LibreOffice/unoconv Integration Issues in Installation Script
Fix: Stirling-PDF > LibreOffice/unoconv Integration Issues
Jan 9, 2025
MickLesk
previously approved these changes
Jan 9, 2025
michelroegl-brunner
dismissed stale reviews from MickLesk and themself
via
January 9, 2025 18:09
501c1f8
michelroegl-brunner
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✍️ Description
The current installation script for the StirlingPDF LXC has issues with LibreOffice and unoconv integration, causing document conversion failures. These issues are caused by the following:
Issues with document conversion and missing environmental variables were resolved by:
🛠️ Type of Change
Please check the relevant options:
✅ Prerequisites
The following steps must be completed for the pull request to be considered:
📋 Additional Information (optional)
Provide any extra context or screenshots about the feature or fix here.