Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to emsdk 3.1.73 #224

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

mcbarton
Copy link
Collaborator

Description

Please include a summary of changes, motivation and context for this PR.

This is a PR to upgrade the emsdk version we use to version 3.1.73, once emscripten forge is finished with its transition to this version.

Fixes # (issue)

Type of change

Please tick all options which are relevant.

  • Bug fix
  • New feature
  • Added/removed dependencies
  • Required documentation updates

@mcbarton mcbarton requested a review from anutosh491 January 16, 2025 21:04
@codecov-commenter
Copy link

codecov-commenter commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.72%. Comparing base (8f79e18) to head (26091d5).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #224   +/-   ##
=======================================
  Coverage   80.72%   80.72%           
=======================================
  Files          19       19           
  Lines         970      970           
  Branches       93       93           
=======================================
  Hits          783      783           
  Misses        187      187           

@@ -22,7 +22,6 @@ jobs:
include:
- name: Github-page
os: ubuntu-24.04
emsdk_ver: "3.1.45"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect

@@ -3,7 +3,7 @@ channels:
- https://repo.mamba.pm/emscripten-forge
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahhh we need to use the correct channel here. I think all updated packages built with the new version are being uploaded to
https://repo.prefix.dev/emscripten-forge-dev

See here https://prefix.dev/channels/emscripten-forge-dev/packages/cppinterop

@anutosh491
Copy link
Collaborator

I expect the build to pass, but we should replicate this locally and try what works as of now (atleast the example notebook again from start) and only then we can ensure this is the change to make. Cause the CI would pass anyways but we don't test the example notebook hence though stuff builds it might not run completely I'm guessing untill we try !

@@ -198,23 +198,22 @@ jobs:
include:
- name: ubu24
os: ubuntu-24.04-arm
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to ubuntu-24.04
for now. I see some error involving mamba here. I've raised it to the mamba folks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants