CS6.2 - Event improvements #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluffywaffles
approved these changes
Oct 15, 2024
hayesgm
reviewed
Oct 15, 2024
| // Note: even with a valid submission token, we always set non-replayables to exhausted (e.g. for cancellations) | ||
| submissions[msg.sender][nonce] = isReplayable ? submissionToken : EXHAUSTED; | ||
| // Note: Even with a valid submission token, we always set non-replayables to exhausted (e.g. for cancellations) | ||
| submissionToken = isReplayable ? submissionToken : EXHAUSTED; |
There was a problem hiding this comment.
Can you call this a new variable name?
There was a problem hiding this comment.
Renamed to finalSubmissionToken.
kevincheng96
force-pushed
the
kevin/improve-events
branch
from
87241b0 to
e9691d8
Compare
kevincheng96
force-pushed
the
kevin/improve-events
branch
from
e9691d8 to
96a33a8
Compare
kevincheng96
commented
Oct 17, 2024
| @@ -19,7 +19,7 @@ contract QuarkNonceManager { | |||
| error InvalidNonce(address wallet, bytes32 nonce); | |||
| error InvalidSubmissionToken(address wallet, bytes32 nonce, bytes32 submissionToken); | |||
|
|
|||
| event NonceSubmitted(address wallet, bytes32 nonce, bytes32 submissionToken); | |||
| event NonceSubmitted(address indexed wallet, bytes32 indexed nonce, bytes32 submissionToken); | |||
There was a problem hiding this comment.
I also just added an index on nonce since it could be useful for replayable operations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some small improvements to events:
walletandnoncefields in theNonceSubmittedeventEXHAUSTEDas thesubmissionTokenvalue in theNonceSubmittedevent