first sketch for workspace build #17538
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
1 task
czoido
reviewed
Jan 24, 2025
| if args.path: | ||
| products = [args.path] | ||
| else: # all products | ||
| products = conan_api.workspace.products |
There was a problem hiding this comment.
We should to check here that products is defined and throw and exception or warning message or it will throw an ugly error because its None
czoido
reviewed
Jan 24, 2025
| @@ -48,7 +49,8 @@ def get_builtin_template(template_name): | |||
| "autotools_exe": autotools_exe_files, | |||
| "alias": alias_file, | |||
| "local_recipes_index": local_recipes_index_files, | |||
| "qbs_lib": qbs_lib_files} | |||
| "qbs_lib": qbs_lib_files, | |||
| "workspace": workspace_files} | |||
There was a problem hiding this comment.
I think we also have to add this to the --help message
czoido
reviewed
Jan 24, 2025
| "lib1/conanfile.py": GenConanfile("lib1", "0.1"), | ||
| "product_app1/conanfile.py": GenConanfile("app1", "0.1")}) | ||
| c.run("workspace add lib1") | ||
| c.run("workspace add product_app1") |
There was a problem hiding this comment.
One small detail: doing some tests I found that if you do a conan workspace remove myproduct the product is removed from the editable list but not from the products list. I think we want to remote the product from the products in the yaml too?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Feature: Initial
conan workspace buildcommand to build the full workspace, based on the definition ofproductsDocs: https://github.com/conan-io/docs/pull/XXXX
Close #17305