Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add secrets support #366

Merged
merged 1 commit into from
Apr 23, 2024
Merged

Conversation

JasonDictos
Copy link
Contributor

This adds the ssh identity support to the concourse yaml

Original work: #331

Tests pass locally however I cannot determine why the concourse-ci/status failed

@JasonDictos JasonDictos requested a review from xtremerui as a code owner April 11, 2024 21:15
@JasonDictos JasonDictos force-pushed the jdictos/docker-secrets branch from 544f7c7 to e818bea Compare April 11, 2024 21:15
@JasonDictos JasonDictos mentioned this pull request Apr 11, 2024
@xtremerui
Copy link
Contributor

Hi @JasonDictos , thank you for the PR. Is there any reason to include the go.mod bumps in this PR? If not, please extract them to keep this PR lean.

@JasonDictos
Copy link
Contributor Author

Hi @JasonDictos , thank you for the PR. Is there any reason to include the go.mod bumps in this PR? If not, please extract them to keep this PR lean.

@xtremerui Done

Signed-off-by: Jason Dictos <jdictos@een.com>
@JasonDictos JasonDictos force-pushed the jdictos/docker-secrets branch from e818bea to d6b861c Compare April 18, 2024 17:04
@xtremerui xtremerui merged commit 93a4fe2 into concourse:master Apr 23, 2024
2 checks passed
@JasonDictos JasonDictos deleted the jdictos/docker-secrets branch April 23, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants