-
-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Noarch variant blog post #2332
Noarch variant blog post #2332
Conversation
✅ Deploy Preview for conda-forge-previews ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
pre-commit.ci auto-fix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the noise, just tried to capitalize Python in all its ocurrences. Also suggested to add a TLDR at the beginning so we can have a self-contained intro broken by the "Read more" link introduced by the <!-- truncate -->
magic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Do you have a list of packages where you want to implement that? Just curious.
Not really. I was looking at packages in my dev environment that had compiled extensions. |
I'll keep this open for a couple of days for comments and merge. Thanks for the reviews. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small nit/question, rest looks good!
Possible improvements:
- I think it would be helpful to provide some things to look for for contributors to tell whether a given package has a pure python fallback implementation, because not all do...
- We might want to reference the efforts around abi3 & limited ABI, which are kind of adjacent in terms of thrust (while they are compiled, they'd still be usable immediately when a new python implementation/variant comes out).
In the Python world, some packages are written in C/C++/Cython | ||
to get the most performance out of a package. However these packages | ||
have a reference implementation written in Python. The Python |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing "often"?
In the Python world, some packages are written in C/C++/Cython | |
to get the most performance out of a package. However these packages | |
have a reference implementation written in Python. The Python | |
In the Python world, some packages are written in C/C++/Cython | |
to get the most performance out of a package. However these packages | |
often have a reference implementation written in Python. The Python |
I don't want to start announcing those things until they are ready. |
@jaimergp any idea on the CI failure? |
We don't use Go for anything. Push an empty commit to see if it was a flaky thing on Netlify's side and if not I'll check tomorrow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Isuru! 🙏
Had a few suggestions below
Think it would be nice to embed an example from your work with a little discussion about how you added it. This may help others pick up this effort and carry it forward
We list some PRs here as a reference for conda-forge maintainers who | ||
want to help out with this effort. | ||
|
||
- [coverage](https://github.com/conda-forge/coverage-feedstock/pull/123) | ||
- [cython](https://github.com/conda-forge/cython-feedstock/pull/147) | ||
- [aiohttp](https://github.com/conda-forge/aiohttp-feedstock/pull/99) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be nice for readers to include an example from a simple one in the blogpost itself. Perhaps could use a diff format to highlight relevant changes
Co-authored-by: jaimergp <jaimergp@users.noreply.github.com>
Co-authored-by: jakirkham <jakirkham@gmail.com>
d1aa79a
to
86c56a1
Compare
Co-authored-by: h-vetinari <h.vetinari@gmx.com>
pre-commit.ci autofix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with the text, but I'd like to provide a smoother on-ramp for contributors, since we're asking for help explicitly.
We list some PRs here as a reference for conda-forge maintainers who | ||
want to help out with this effort. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think if we're asking people for help, we need to at least have a tracking issue for discussion and questions, and ideally provide a short list (even if incomplete) of packages that we know have a non-compiled fallback and are "eligible". Otherwise this fails at step 0 IMO - "which feedstock should I tackle?"
pre-commit.ci autofix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Approval is independent of a not very important typo
Co-authored-by: h-vetinari <h.vetinari@gmx.com>
PR Checklist:
docs/
orcommunity/
, you have added it to the sidebar in the corresponding_sidebar.json
filecc @ocefpaf @h-vetinari