-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a package for v1.2.0 #2
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@mcbarton, I was wondering what would it take to enable the wasm and windows infrastructure? I think we might need some inspiration from https://github.com/conda-forge/xeus-cpp-feedstock? |
@conda-forge-admin, please rerender |
It looks like xeus-cpp does not have a version under https://github.com/emscripten-forge/recipes/tree/main/recipes yet. |
@conda-forge-admin, please rerender |
@conda-forge-admin, please rerender |
…nda-forge-pinning 2024.03.02.16.55.54
@vgvassilev I will look at this in more detail later today, but the first things which stand out to me are. In the CI when building on Windows we do not build the shared library so this needs to be remove I don't understand why this is referencing a Linux folder CppInterOp also works for arm, so maybe have the name of the folders include the architecture name (also assuming this bash script is also used for osx, then the reference to linux folders should be different on osx). On a similar note, there is no arm machines mentionn the ci support folder, as far as I can tell. cc: @alexander-penev |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipe:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@vgvassilev I can't see in https://github.com/conda-forge/xeus-cpp-feedstock where they are doing the wasm build. A wasm build cannot make use the llvmdev in Conda-forge as it stands as it forces on zstd (see https://github.com/conda-forge/llvmdev-feedstock/blob/fe9f6c862670e0837b7630d958bf3597e9011914/recipe/build.sh#L44 ). There is currently no build of zstd in https://repo.mamba.pm/emscripten-forge we could make use of for CppInterOp build. How easily do you think it would be to get this changed? |
@mcbarton, that seems to be still a PR: emscripten-forge/recipes#737
Doesn't emscripten-forge have its own package for LLVM? Can't we use it instead? |
Yes emscripten-forge has its own llvm-dev here https://github.com/emscripten-forge/recipes/blob/main/recipes/recipes_emscripten/llvm/build.sh. Have you put in any PRs relevant to CppInterOp to llvm 17 since version 17.0.4 since that's the one its building? See https://github.com/emscripten-forge/recipes/blob/ddcb55bf747a57b409b7a805220178c8b750e9f5/recipes/recipes_emscripten/llvm/recipe.yaml#L2C1-L3C1 |
We have not - CppInterOp should be compatible with 17.0.4. |
If you know someone who can get it reviewed and approved, then I can make a start on a recipe for CppInterOp in emscripten-forge sometime in the next few days if you would like. |
Yes, we do. Maybe we should try doing this to unblock compiler-research/xeus-cpp#14. |
Ok. Once I have a draft of a recipe ready for testing I will cc you in the PR, and we can take it from there. |
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)