Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trim down supported file extensions on Windows and Linux #183

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

ccordoba12
Copy link
Contributor

@ccordoba12 ccordoba12 commented Aug 28, 2024

Fixes spyder-ide/spyder#22389.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@ccordoba12
Copy link
Contributor Author

@mrclary, could you take a look at this one? Thanks!

@mrclary
Copy link
Contributor

mrclary commented Aug 28, 2024

Let me take a look at this. I agree that Spyder should not be the default application, but it should be in the "Open with..." context menu and these files should be openable from a Spyder open-file dialogue.

Copy link
Contributor

@mrclary mrclary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ccordoba12, I still need to test this PR, but at least the trailing commas in lists need to be removed, otherwise JSONDecodeError results.

recipe/spyder-menu.json Outdated Show resolved Hide resolved
recipe/spyder-menu.json Outdated Show resolved Hide resolved
recipe/spyder-menu.json Outdated Show resolved Hide resolved
recipe/spyder-menu.json Outdated Show resolved Hide resolved
@ccordoba12 ccordoba12 force-pushed the trim-file-extensions branch from fe2b3ff to 7c8aadb Compare August 30, 2024 15:59
@ccordoba12 ccordoba12 changed the title Trim down supported file extensions per OS Trim down supported file extensions on Windows and Linux Aug 30, 2024
@ccordoba12
Copy link
Contributor Author

@mrclary, this is ready for another review.

Copy link
Contributor

@mrclary mrclary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me; thanks @ccordoba12

@ccordoba12 ccordoba12 added the automerge Merge the PR when CI passes label Aug 30, 2024
@github-actions github-actions bot merged commit ab4ddbf into conda-forge:dev Aug 30, 2024
26 checks passed
Copy link
Contributor

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: passed

Thus the PR was passing and merged! Have a great day!

@ccordoba12 ccordoba12 deleted the trim-file-extensions branch August 30, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the PR when CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants