Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Bagels #28787

Merged
merged 2 commits into from
Jan 22, 2025
Merged

Add Bagels #28787

merged 2 commits into from
Jan 22, 2025

Conversation

claudiushaag
Copy link
Contributor

@claudiushaag claudiushaag commented Jan 8, 2025 •
edited
Loading

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@claudiushaag
Initial try
7f48b16 
Problems:
+ usage of pydantic-settings-yaml not clear -> only on pypi, no conda package
+ patch for xdg-base-dirs does not work:
    - "could not find patch executable"
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 8, 2025

Hi! This is the staged-recipes linter and I found some lint.

File-specific lints and/or hints:

  • recipes/bagels/recipe.yaml:
    • lints:
      • The following maintainers have not yet confirmed that they are willing to be listed here: EnhancedJax. Please ask them to comment on this PR if they are.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/bagels/recipe.yaml) and found it was in an excellent condition.

@claudiushaag
Copy link
Contributor Author

@conda-forge/help-python I would need some help here -linux and osx fails with $PREFIX/bin/python: No module named pip?

This seems weird, as pip is listed as a host requirement.

@claudiushaag claudiushaag mentioned this pull request Jan 8, 2025
Closed
@EnhancedJax
Copy link

Creator here! Happy to have bagels hosted on conda!

@ocefpaf
Copy link
Member

ocefpaf commented Jan 8, 2025

@conda-forge/help-python I would need some help here -linux and osx fails with $PREFIX/bin/python: No module named pip?

@wolfv this is a v1 recipe and I'm still not 100% comfortable reviewing it. If you have some time can you take a look?

@github-actions GitHub Actions
Copy link
Contributor

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@ocefpaf ocefpaf merged commit 07167b1 into conda-forge:main Jan 22, 2025
7 checks passed
@wolfv
Copy link
Member

wolfv commented Jan 22, 2025

Looks good! Sorry for the late reply @ocefpaf :)

@claudiushaag claudiushaag deleted the bagels branch January 22, 2025 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
python review-requested
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@claudiushaag @conda-forge-admin @EnhancedJax @ocefpaf @wolfv