Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a recipe for swan (https://swanmodel.sourceforge.io/) #28795

Merged
merged 10 commits into from
Jan 23, 2025

Conversation

martin-g
Copy link
Contributor

@martin-g martin-g commented Jan 9, 2025

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

Copy link
Contributor

github-actions bot commented Jan 9, 2025

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Jan 9, 2025

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/swan/meta.yaml) and found some lint.

Here's what I've got...

For recipes/swan/meta.yaml:

  • ❌ license_file entry is missing, but is required.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12685948400. Examine the logs at this URL for more detail.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/swan/meta.yaml) and found it was in an excellent condition.

@martin-g martin-g marked this pull request as ready for review January 9, 2025 12:06
@martin-g
Copy link
Contributor Author

@conda-forge/help-c-cpp this is ready for review

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/swan/recipe.yaml) and found some lint.

Here's what I've got...

For recipes/swan/recipe.yaml:

  • ❌ There are 1 too many lines. There should be one empty line at the end of the file.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12810017609. Examine the logs at this URL for more detail.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/swan/recipe.yaml) and found it was in an excellent condition.

martin-g and others added 9 commits January 16, 2025 16:40
Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
…on of Fortran

Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
All *.f / *.f90 files have GPL3 header, but there is no explicit LICENSE
file in the tarball.

Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
run:
- openmpi
run_exports:
- ${{ pin_subpackage(name, upper_bound='x') }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there is a shared library, please test for its existence.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure what makes you think there is such.
meta.yaml (v0) used - {{ pin_subpackage(name, max_pin='x') }}
conda-recipe-converter (rattler-build) converted it to dependencies > run_exports >...

Only the binaries are needed. No static libraries.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#28726 (comment)
I think I understand! run_exports should be used only when the recipe produces a shared library! Makes sense!

In Bioconda it is mandatory for all recipes and I added it automatically...

@martin-g martin-g mentioned this pull request Jan 23, 2025
10 tasks
It is needed only when the recipe produces a shared library

Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
@xhochy xhochy merged commit 9fa4947 into conda-forge:main Jan 23, 2025
7 checks passed
@martin-g martin-g deleted the swan branch January 23, 2025 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants