-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a recipe for swan (https://swanmodel.sourceforge.io/) #28795
Conversation
Hi! This is the staged-recipes linter and your PR looks excellent! 🚀 |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/swan/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12685948400. Examine the logs at this URL for more detail. |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge/help-c-cpp this is ready for review |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/swan/recipe.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12810017609. Examine the logs at this URL for more detail. |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
…on of Fortran Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
All *.f / *.f90 files have GPL3 header, but there is no explicit LICENSE file in the tarball. Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
recipes/swan/recipe.yaml
Outdated
run: | ||
- openmpi | ||
run_exports: | ||
- ${{ pin_subpackage(name, upper_bound='x') }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If there is a shared library, please test for its existence.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure what makes you think there is such.
meta.yaml
(v0) used - {{ pin_subpackage(name, max_pin='x') }}
conda-recipe-converter (rattler-build) converted it to dependencies > run_exports >...
Only the binaries are needed. No static libraries.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#28726 (comment)
I think I understand! run_exports
should be used only when the recipe produces a shared library! Makes sense!
In Bioconda it is mandatory for all recipes and I added it automatically...
It is needed only when the recipe produces a shared library Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).