Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disk space checks should come earlier and use MB in the message #889

Merged
merged 5 commits into from
Nov 9, 2024

Conversation

jaimergp
Copy link
Contributor

@jaimergp jaimergp commented Nov 8, 2024

Description

Close #774

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@jaimergp jaimergp requested a review from a team as a code owner November 8, 2024 13:11
@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Nov 8, 2024
constructor/header.sh Outdated Show resolved Hide resolved
Copy link
Contributor

@marcoesters marcoesters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Even though you might consider removing $PREFIX if it was newly created.

@jaimergp jaimergp merged commit 9a10ec5 into conda:main Nov 9, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed [bot] added once the contributor has signed the CLA
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Improve disk space check for sh installers
3 participants