Skip to content
This repository has been archived by the owner on Feb 20, 2024. It is now read-only.

rename schema registry ports + add early failure condition #593

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/cp-schema-registry/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ spec:
image: "{{ .Values.image }}:{{ .Values.imageTag }}"
imagePullPolicy: "{{ .Values.imagePullPolicy }}"
ports:
- name: schema-registry
- name: http
containerPort: {{ .Values.servicePort }}
protocol: TCP
{{- if .Values.prometheus.jmx.enabled }}
Expand Down
9 changes: 7 additions & 2 deletions charts/cp-schema-registry/templates/service.yaml
Original file line number Diff line number Diff line change
@@ -1,15 +1,20 @@
{{- $servicename := (include "cp-schema-registry.fullname" .) -}}
{{ if or (eq $servicename "schema-registry") (eq $servicename "schema_registry") }}
{{- fail "setting fullname to schema registry will require app to fail due to host environments: https://kubernetes.io/docs/concepts/services-networking/connect-applications-service/#environment-variables" }}
{{- end -}}

apiVersion: v1
kind: Service
metadata:
name: {{ template "cp-schema-registry.fullname" . }}
name: {{ $servicename }}
labels:
app: {{ template "cp-schema-registry.name" . }}
chart: {{ template "cp-schema-registry.chart" . }}
release: {{ .Release.Name }}
heritage: {{ .Release.Service }}
spec:
ports:
- name: schema-registry
- name: http
port: {{ .Values.servicePort }}
{{- if .Values.prometheus.jmx.enabled }}
- name: metrics
Expand Down