[DGS-18780] Ensure p99 metrics are correctly published #519
+32
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pritishatx
changed the title
| ).define( | ||
| PERCENTILE_MAX_LATENCY_MS_CONFIG, | ||
| Type.DOUBLE, | ||
| PERCENTILE_MAX_LATENCY_MS_DEFAULT, |
There was a problem hiding this comment.
[minor] we should have put the validation here to avoid non positive value
There was a problem hiding this comment.
Sure, let me get back with a fix for this.
There was a problem hiding this comment.
Hi @trnguyencflt, raised a PR to add the validation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We noticed that the percentile latency metrics in rest-utils (request-latency-95 and request-latency-99) are capped out at 10s (code ref).
The PR makes PERCENTILE_MAX_LATENCY_IN_MS configurable in RestConfig, with 10s as the default value.
Slack thread